Closed Bug 838839 Opened 10 years ago Closed 10 years ago

Remove deprecated synchronous favicons APIs

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: dev-doc-needed)

Attachments

(1 file, 1 obsolete file)

patch v1.1
51.14 KB, patch
asaf
: review+
Gavin
: superreview+
Details | Diff | Splinter Review 
Another piece going.
Blocks: 834457
Attached patch patch v1.0 (obsolete) — — Splinter Review 
A couple notes:

1. the XXXIfAvailable helpers were been added lots of time ago before I did the Database.cpp refactoring, when I refactored the shutdown code I didn't remove them. Since I was removing the entry in favicons I just removed the others in bookmarks and annotations.

2. mFaviconsExpirationRunning was used to avoid sync APIs adding stuff while async expiration was running, by mistake it was then added also to async APIs, but actually they don't need it since everything on a connection is serialized.

As usual, will hit Try before landing.
Attachment #711005 - Flags: review?(mano)
Comment on attachment 711005 [details] [diff] [review]
patch v1.0

Review of attachment 711005 [details] [diff] [review]:
-----------------------------------------------------------------

I must unbitrot the patch due to recent changes to notify deprecation, though we can proceed with SR in parallel to the review
Attachment #711005 - Flags: superreview?(gavin.sharp)
Attached patch patch v1.1 — — Splinter Review 
just an unbitrot
Attachment #711005 - Attachment is obsolete: true
Attachment #711005 - Flags: superreview?(gavin.sharp)
Attachment #711005 - Flags: review?(mano)
Attachment #719398 - Flags: superreview?(gavin.sharp)
Attachment #719398 - Flags: review?(mano)
Comment on attachment 719398 [details] [diff] [review]
patch v1.1

The forward declaration of nsIFaviconDataCallback at the top of nsIFaviconService should no longer be needed.
Attachment #719398 - Flags: superreview?(gavin.sharp) → superreview+
Attachment #719398 - Flags: review?(mano) → review+
https://hg.mozilla.org/mozilla-central/rev/c9c29cc97af0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.