Remove deprecated synchronous favicons APIs

RESOLVED FIXED in mozilla22

Status

()

Toolkit
Places
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

({dev-doc-needed})

Trunk
mozilla22
dev-doc-needed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Another piece going.
(Assignee)

Updated

4 years ago
Blocks: 834457
(Assignee)

Comment 1

4 years ago
Created attachment 711005 [details] [diff] [review]
patch v1.0

A couple notes:

1. the XXXIfAvailable helpers were been added lots of time ago before I did the Database.cpp refactoring, when I refactored the shutdown code I didn't remove them. Since I was removing the entry in favicons I just removed the others in bookmarks and annotations.

2. mFaviconsExpirationRunning was used to avoid sync APIs adding stuff while async expiration was running, by mistake it was then added also to async APIs, but actually they don't need it since everything on a connection is serialized.

As usual, will hit Try before landing.
Attachment #711005 - Flags: review?(mano)
(Assignee)

Comment 2

4 years ago
Comment on attachment 711005 [details] [diff] [review]
patch v1.0

Review of attachment 711005 [details] [diff] [review]:
-----------------------------------------------------------------

I must unbitrot the patch due to recent changes to notify deprecation, though we can proceed with SR in parallel to the review
Attachment #711005 - Flags: superreview?(gavin.sharp)
(Assignee)

Comment 3

4 years ago
Created attachment 719398 [details] [diff] [review]
patch v1.1

just an unbitrot
Attachment #711005 - Attachment is obsolete: true
Attachment #711005 - Flags: superreview?(gavin.sharp)
Attachment #711005 - Flags: review?(mano)
Attachment #719398 - Flags: superreview?(gavin.sharp)
Attachment #719398 - Flags: review?(mano)
Comment on attachment 719398 [details] [diff] [review]
patch v1.1

The forward declaration of nsIFaviconDataCallback at the top of nsIFaviconService should no longer be needed.
Attachment #719398 - Flags: superreview?(gavin.sharp) → superreview+
Attachment #719398 - Flags: review?(mano) → review+
(Assignee)

Comment 5

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9c29cc97af0
Target Milestone: --- → mozilla22
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/c9c29cc97af0
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.