Add a JS_STANDALONE configure/make variable

RESOLVED FIXED in Firefox 21

Status

Firefox Build System
General
RESOLVED FIXED
5 years ago
4 months ago

People

(Reporter: ted, Assigned: glandium)

Tracking

unspecified
mozilla21

Firefox Tracking Flags

(firefox20 wontfix, firefox21 fixed, firefox-esr17 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We should have a configure/make variable that indicates whether Spidermonkey is being built standalone. I think we could just pass this down as =0 from the top-level configure, and default it to =1 if it's unset.

Comment 1

5 years ago
Created attachment 711221 [details] [diff] [review]
JS_STANDALONE

So, something alone the lines of this patch then? top-level configure or client.mk would need to gain an 'export MOZILLA_BUILD'
(Assignee)

Comment 2

5 years ago
Comment on attachment 711221 [details] [diff] [review]
JS_STANDALONE

Review of attachment 711221 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/Makefile.in
@@ -37,4 @@
>  SRCREL_ABI_VERSION  := $(word 1,$(subst ., ,$(SRCREL_VERSION)))
>  
>  MODULE		    = js
> -ifneq (,$(MOZILLA_OFFICIAL))

That comes from bug 812265, but the dependency is the other way around: the patch from bug 812265 will have to be rewritten after this one.

::: js/src/configure.in
@@ +3924,5 @@
> +    JS_STANDALONE=0 )
> +if test -n "$MOZILLA_BUILD"; then
> +    JS_STANDALONE=0
> +fi
> +AC_DEFINE_UNQUOTED(JS_STANDALONE, $JS_STANDALONE)

Since it's going to be used in Makefile.in, it's AC_SUBST ; and we don't need a full-fledged configure option for that.
(Assignee)

Comment 3

5 years ago
Created attachment 711225 [details] [diff] [review]
Add a JS_STANDALONE configure/make variable
Attachment #711225 - Flags: review?(ted)
(Assignee)

Updated

5 years ago
Assignee: ted → mh+mozilla
(Assignee)

Updated

5 years ago
Attachment #711221 - Attachment is obsolete: true
Comment on attachment 711221 [details] [diff] [review]
JS_STANDALONE

Pretty close, yeah. I wouldn't bother adding a configure argument though, we can just export JS_STANDALONE=0 from the top-level configure.
Comment on attachment 711225 [details] [diff] [review]
Add a JS_STANDALONE configure/make variable

Review of attachment 711225 [details] [diff] [review]:
-----------------------------------------------------------------

Sold.
Attachment #711225 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/d17e8470d7d9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Comment on attachment 711225 [details] [diff] [review]
Add a JS_STANDALONE configure/make variable

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:

Necessary for the mozjs17 standalone release of the JS engine. Defines JS_STANDALONE for a standalone release. Does not affect non-standalone builds.

User impact if declined:

The patch is necessary for the upcoming JS standalone release based on esr17. If declined, the patch will have to be carried separately from the main repository for the lifetime of mozjs17 support.

Declining will also prevent Bug 812265 (proper library versioning) from landing on esr17.

Fix Landed on Version: 21
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #711225 - Flags: approval-mozilla-esr17?

Comment 9

5 years ago
Comment on attachment 711225 [details] [diff] [review]
Add a JS_STANDALONE configure/make variable

Basically a NPOTB change in support of external packages. Approving.
Attachment #711225 - Flags: approval-mozilla-esr17? → approval-mozilla-esr17+
status-firefox20: --- → wontfix
status-firefox21: --- → fixed
status-firefox-esr17: --- → fixed

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.