Closed Bug 838964 Opened 11 years ago Closed 8 years ago

validate toolbar items before using them

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: markh, Unassigned)

Details

We currently blindly attempt to use the "ambient" toolbar icon information from a provider, even though it may have missing/invalid attributes we care about.  Eg, with no iconURL we will attempt to set an invalid listStyleImage, and without a label attribute we will set the tooltip text/label to the string "undefined".

We should validate the data and complain noisily and ignore the toolbar item when it is invalid.
deprecation in fx51
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.