Closed Bug 838981 Opened 11 years ago Closed 11 years ago

update tab related modules to ignore private windows when they are not supported

Categories

(Add-on SDK Graveyard :: General, defect, P1)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evold, Assigned: ochameau)

References

Details

Attachments

(1 file, 3 obsolete files)

Pull request 830
165 bytes, text/html
irakli
: review+
Details 
      No description provided.
Assignee: nobody → evold
Blocks: sdk-pwpb
Target Milestone: --- → 1.14
Depends on: 834961
Attachment #711218 - Flags: review?(rFobic)
Comment on attachment 711218 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/771

I have rejected either superset or subset of this for few things that are part of this change. So I'm rejecting this one too. I'm little lost because of many pull requests with same changes at this point, hopefully you'll be able to find the once containing comments.
Attachment #711218 - Flags: review?(rFobic) → review-
the tab-browser and tab/utils modules to ignore private windows/tabs
Summary: Test that tab-browser ignores private windows when they are not supported → update tab related modules to ignore private windows when they are not supported
Attached file Pull request 820 (obsolete) — 

        Attachment #719062 -
        Flags: review?

    
    

    
  

      
      
      
      

        Attached file
          
        Pull request 820 (obsolete)
        — 
      

    


  
Here I return null for activeTab if the addon doesn't have private-browsing permission and the top-most window is private. Should I try to return the top-most non-private tab instead?

If that patch looks correct to you, I can continue on top-level tabs API.
Assignee: evold → poirot.alex

        Attachment #711218 -
        Attachment is obsolete: true

        Attachment #719062 -
        Attachment is obsolete: true

        Attachment #719062 -
        Flags: review?

        Attachment #719065 -
        Flags: review?(rFobic)

        Attachment #719065 -
        Flags: review?(evold)

    
    

    
  

      
      
      
      

        Attached file
          
        Pull request 830
        — 
      

    


  
I'm not sure how relevant it is to ignore private tabs for tab-browser, so I focused on tabs high level API.
There is some indentation and better comment phrasing modification in this pull request that aren't necessarely directly related to this bug.

        Attachment #720676 -
        Flags: review?(evold)

        Attachment #720676 -
        Flags: review?(evold) → review+

    
  

        Attachment #719065 -
        Flags: review?(evold)

    
    

    
  
Comment on attachment 719065 [details]
Pull request 820

Just opened bug 838981. So instead of making tab-browser private-browsing aware, we will start deprecating it.

        Attachment #719065 -
        Attachment is obsolete: true

    
    

    
  
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/282229fddace3f7f4b0a85e8a6bd303fce3b1be8
Bug 838981: Ignore private window in tabs API when addon doesn't have private-browsing permission.

https://github.com/mozilla/addon-sdk/commit/a9345e76f37155b32dfb8d6d25ea4df5b7f1e18f
Merge pull request #830 from ochameau/tabs-pb

Bug 838981: Ignore private window in tabs API when addon doesn't have private-browsing permission. r=@gozala
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
    

    
  
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/01ca9c7d8b3303cb2ca57cf1c679f73ad4697f3d
Merge pull request #830 from ochameau/tabs-pb

Bug 838981: Ignore private window in tabs API when addon doesn't have private-browsing permission. r=@gozala(cherry picked from commit a9345e76f37155b32dfb8d6d25ea4df5b7f1e18f)

    
    

    
  
Commits pushed to integration at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/282229fddace3f7f4b0a85e8a6bd303fce3b1be8
Bug 838981: Ignore private window in tabs API when addon doesn't have private-browsing permission.

https://github.com/mozilla/addon-sdk/commit/a9345e76f37155b32dfb8d6d25ea4df5b7f1e18f
Merge pull request #830 from ochameau/tabs-pb
Blocks: 852338
No longer blocks: 852338

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: