Closed
Bug 839022
Opened 11 years ago
Closed 11 years ago
Convert HTMLSourceElement to WebIDL
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: baku, Assigned: baku)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 3 obsolete files)
|
9.99 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
6.79 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #711272 -
Flags: review?(Ms2ger)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #711273 -
Flags: review?(Ms2ger)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Pushed to try
|
||
Comment 4•11 years ago
|
||
Comment on attachment 711272 [details] [diff] [review] part 1 - renaming Review of attachment 711272 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/html/content/src/nsHTMLSourceElement.cpp @@ +6,2 @@ > > +#include "HTMLSourceElement.h" The usual ::: content/html/content/src/Makefile.in @@ +45,5 @@ > HTMLParagraphElement.h \ > HTMLPreElement.h \ > HTMLScriptElement.h \ > HTMLSharedListElement.h \ > + HTMLSourceElement.h \ Looks like we need an ifdef MOZ_MEDIA block.
Attachment #711272 -
Flags: review?(Ms2ger) → review+
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 711273 [details] [diff] [review] part 2 - webidl Review of attachment 711273 [details] [diff] [review]: ----------------------------------------------------------------- You forgot the hasInstanceInterface bit. Also, MOZ_MEDIA checks.
Attachment #711273 -
Flags: review?(Ms2ger) → review-
|
|
Assignee | |
Comment 6•11 years ago
|
||
Attachment #711272 -
Attachment is obsolete: true
Attachment #711291 -
Flags: review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
Attachment #711273 -
Attachment is obsolete: true
Attachment #711292 -
Flags: review?(Ms2ger)
|
|
||
Comment 8•11 years ago
|
||
Comment on attachment 711292 [details] [diff] [review] part 2 - webidl Review of attachment 711292 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/html/content/src/HTMLSourceElement.cpp @@ +78,5 @@ > } > > +JSObject* > +HTMLSourceElement::WrapNode(JSContext* aCx, JSObject* aScope, > + bool* aTriedToWrap) Indentation ::: content/html/content/src/HTMLSourceElement.h @@ +52,5 @@ > + void GetSrc(nsString& aSrc) > + { > + GetURIAttr(nsGkAtoms::src, nullptr, aSrc); > + } > + void SetSrc(const nsAString& aSrc, mozilla::ErrorResult& rv) mozilla::
Attachment #711292 -
Flags: review?(Ms2ger) → review+
|
|
Assignee | |
Comment 9•11 years ago
|
||
Attachment #711292 -
Attachment is obsolete: true
Attachment #711330 -
Flags: review?(Ms2ger)
|
|
||
Updated•11 years ago
|
Attachment #711330 -
Flags: review?(Ms2ger) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/964d45caa4dc https://hg.mozilla.org/integration/mozilla-inbound/rev/9115c9395925
Keywords: checkin-needed
|
|
||
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/964d45caa4dc https://hg.mozilla.org/mozilla-central/rev/9115c9395925
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•