Convert HTMLProgressElement to WebIDL

RESOLVED FIXED in mozilla21

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

(Blocks: 1 bug)

Trunk
mozilla21
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 711288 [details] [diff] [review]
part 1 - renaming
Attachment #711288 - Flags: review?(Ms2ger)
(Assignee)

Comment 2

5 years ago
Created attachment 711289 [details] [diff] [review]
part 2 - webidl
Attachment #711289 - Flags: review?(Ms2ger)
(Assignee)

Comment 3

5 years ago
Created attachment 711294 [details] [diff] [review]
part 2 - webidl
Attachment #711289 - Attachment is obsolete: true
Attachment #711289 - Flags: review?(Ms2ger)
Attachment #711294 - Flags: review?(Ms2ger)

Updated

5 years ago
Attachment #711288 - Flags: review?(Ms2ger) → review+

Updated

5 years ago
Attachment #711294 - Flags: review?(Ms2ger) → review+
Created attachment 711321 [details] [diff] [review]
part 3 - cleanup

I think it's better to implement it this way.
Attachment #711321 - Flags: review?(mounir)
Attachment #711321 - Flags: review?(mounir) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Backed out for build bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8e8b2be32e6

https://tbpl.mozilla.org/php/getParsedLog.php?id=19611157&tree=Mozilla-Inbound

HTMLSharedElement.cpp
rm -f libgkcondash_s.a 
/builds/slave/m-in-osx64/build/obj-firefox/i386/_virtualenv/bin/python /builds/slave/m-in-osx64/build/config/expandlibs_gen.py --depend .deps/libgkcondash_s.a.desc.pp -o libgkcondash_s.a.desc DASHDecoder.o DASHRepDecoder.o DASHReader.o  
/usr/local/bin/ccache /builds/slave/m-in-osx64/build/clang/bin/clang++ -arch i386 -o SVGAnimateMotionElement.o -c  -fvisibility=hidden -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DSTATIC_EXPORTABLE_JS_API -DNO_NSPR_10_SUPPORT -D_IMPL_NS_LAYOUT  -I/builds/slave/m-in-osx64/build/content/svg/content/src -I. -I../../../../dist/include  -I/builds/slave/m-in-osx64/build/obj-firefox/i386/dist/include/nspr -I/builds/slave/m-in-osx64/build/obj-firefox/i386/dist/include/nss     -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../xml/content/src -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../../dom -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../base/src -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../../layout/generic -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../../layout/xul/base/src -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../../layout/svg -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../../layout/style -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../events/src -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../html/content/src -I/builds/slave/m-in-osx64/build/content/xbl/src -I/builds/slave/m-in-osx64/build/content/svg/content/src/../../../smil   -fPIC -Qunused-arguments  -Qunused-arguments -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wno-invalid-offsetof -Wno-c++0x-extensions -Wno-extended-offsetof -Wno-unknown-warning-option -Wno-return-type-c-linkage -Wno-mismatched-tags -isysroot /Developer/SDKs/MacOSX10.6.sdk -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -pthread -DNO_X11 -pipe  -DNDEBUG -DTRIMMED -g -O3 -fno-omit-frame-pointer  -Werror -Wno-error=uninitialized -Wno-error=deprecated-declarations  -Qunused-arguments  -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -MD -MF .deps/SVGAnimateMotionElement.o.pp  /builds/slave/m-in-osx64/build/content/svg/content/src/SVGAnimateMotionElement.cpp
SVGAnimationElement.cpp
../../../../../../content/html/content/src/HTMLProgressElement.cpp:131:1: error: control reaches end of non-void function [-Werror,-Wreturn-type]
}
^
1 error generated.
make[9]: *** [HTMLProgressElement.o] Error 1
(Assignee)

Comment 8

5 years ago
Created attachment 712384 [details] [diff] [review]
part 3 - cleanup

a |return NS_OK;| was missing.
Attachment #711321 - Attachment is obsolete: true
Attachment #712384 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Oops, sorry.
https://hg.mozilla.org/mozilla-central/rev/bcff3820f704
https://hg.mozilla.org/mozilla-central/rev/ecbca463ce66
https://hg.mozilla.org/mozilla-central/rev/0a1aa2cbe096
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21

Updated

5 years ago
Depends on: 842500
You need to log in before you can comment on or make changes to this bug.