Closed
Bug 839056
Opened 11 years ago
Closed 11 years ago
Convert HTMLOptGroupElement to WebIDL
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: baku, Assigned: baku)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
|
13.10 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
|
8.51 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•11 years ago
|
Blocks: ParisBindings, 826738
|
||
Updated•11 years ago
|
No longer blocks: ParisBindings, 826738
|
|
Assignee | |
Updated•11 years ago
|
Blocks: ParisBindings, 826738
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #711364 -
Flags: review?(Ms2ger)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #711365 -
Flags: review?(Ms2ger)
|
||
Updated•11 years ago
|
Attachment #711364 -
Flags: review?(Ms2ger) → review+
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 711365 [details] [diff] [review] part 2 - webidl Review of attachment 711365 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/html/content/src/HTMLOptGroupElement.h @@ +67,5 @@ > + } > + > + > + // The XPCOM GetLabel is OK for us > + void SetLabel(const nsAString& aLabel, ErrorResult& aError) No need for two empty lines, I think
Attachment #711365 -
Flags: review?(Ms2ger) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #711365 -
Attachment is obsolete: true
Attachment #711776 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b7d82d4dbd2 https://hg.mozilla.org/integration/mozilla-inbound/rev/de145c9d52ae
Flags: in-testsuite?
Keywords: checkin-needed
|
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3b7d82d4dbd2 https://hg.mozilla.org/mozilla-central/rev/de145c9d52ae
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•