give mozilla::Selection an iid

RESOLVED FIXED in mozilla21

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla21
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

useful for things like bug 839051
Posted patch patch (obsolete) — Splinter Review
Attachment #711313 - Flags: review?(bugs)
Comment on attachment 711313 [details] [diff] [review]
patch

Could we just make nsISelection etc builtinclasses and do static_cast then when
needed?
Comment on attachment 711313 [details] [diff] [review]
patch

I think we should do that. nsISelection has already some
[noscript] stuff.
Attachment #711313 - Flags: review?(bugs)
(In reply to Olli Pettay [:smaug] from comment #2)
> Comment on attachment 711313 [details] [diff] [review]
> patch
> 
> Could we just make nsISelection etc builtinclasses and do static_cast then
> when
> needed?

I'm fine with that if you don't care about c++ addons that decide to implement it themselves
I'd be very surprised if addons implemented nsISelection.
Attachment #711313 - Attachment is obsolete: true
Attachment #712579 - Flags: review?(bugs)
Attachment #712579 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/5ac0eb5c9ba8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.