839080 - BaselineCompiler: Compile object initializer opcodes

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brian Hackett [Laid off!]]

JSOP_NEWOBJECT, JSOP_NEWINIT, JSOP_INITELEM and JSOP_INITPROP are all handled by JM but not by Baseline.  NEWINIT and INITELEM can be stubbed, NEWOBJECT should behave in a similar fashion to NEWARRAY, INITPROP can use a SETPROP cache, slightly modified so that it knows it is doing a define and not a set.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: patch

Patch reusing SETPROP and SETELEM logic for INITPROP and INITELEM, as much as possible.  I get one new failure with this patch in tests/basic/expression-autopsy, but this seems unrelated (the involved script contains a NEWOBJECT so wasn't previously being compiled by baseline).

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 711420 [details] [diff] [review]
patch

Review of attachment 711420 [details] [diff] [review]:
-----------------------------------------------------------------

This actually does look cleaner than going the ScratchValue route.  Bailout shouldn't be a problem either.

I also like the approach for NEWOBJECT of just ImmGCPtring the template object as a parameter to the IC chain.  I'll make a bug to change NEWARRAY to operate the same way.

Comment 3

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/projects/ionmonkey/rev/f21ddc17c570