Closed Bug 839154 Opened 11 years ago Closed 6 years ago

Cache results from AppsService.getAppBy*() that are used immutably

Categories

(Core Graveyard :: DOM: Apps, defect)

Product:
Core Graveyard
Component:
DOM: Apps
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18+ affected)

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
b2g18 + affected

People

(Reporter: cjones, Unassigned)

References

Details

(Keywords: perf) 

+++ This bug was initially created as a clone of Bug #836605 +++

Bug 836605 made the getAppBy*() cheaper, but even after that consumers still show up in profiles.

Have patch to fix but they're failing tests on tbpl that don't fail locally.
I think that the fix for this bug is not risky, but it appears to be causing some (apparently GC-timing-related) test failures on tbpl.  At the moment the win from this patch doesn't outweigh the cost that might be required to wade through the timing issue(s).
bug 835698 comment 54 implies we should eventually fix this here for a nice startup perf boost. So asking for at least tracking here.
tracking-b2g18: --- → ?
Keywords: perf
Product: Core → Core Graveyard
Core Graveyard / DOM: Apps is inactive. Closing all bugs in this component.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.