839157 - update email templates and rendering for l10n

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

In bug #827649, I updated the email templates for the users and questions apps so that they can be localized.

The list of email templates that have yet to be updated are these:

./kbforums/templates/kbforums/email/new_post.ltxt
./kbforums/templates/kbforums/email/new_thread.ltxt
./forums/templates/forums/email/new_post.ltxt
./forums/templates/forums/email/new_thread.ltxt
./messages/templates/messages/email/private_message.ltxt
./wiki/templates/wiki/email/ready_for_review.ltxt
./wiki/templates/wiki/email/approved.ltxt
./wiki/templates/wiki/email/reviewed.ltxt
./wiki/templates/wiki/email/ready_for_l10n.ltxt
./wiki/templates/wiki/email/reviewed_contributors.ltxt
./wiki/templates/wiki/email/edited.ltxt
./announcements/templates/announcements/email/announcement.ltxt

For each of these, the following needs to happen:

1. convert the template from Django to Jinja2
2. fix the code that renders the template to use the functions in sumo.email_utils rather than Django template renderer
3. test vigorously!


Take a look at the rendering code for email templates in the users and questions apps for examples.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is at least 3 points of work.

For each template we have to find the place in the code that renders it (and the email subject!), then fiddle with the code so the subject and body are rendered with the right locale, then change the template to be a Jinja2 template, then figure out how to trigger the condition that sends the email so we can test that it works correctly.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Taking this one. I'll flip between this and Input for the next week.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Reducing the scope of this bug to just the following templates:

./kbforums/templates/kbforums/email/new_post.ltxt
./kbforums/templates/kbforums/email/new_thread.ltxt
./forums/templates/forums/email/new_post.ltxt
./forums/templates/forums/email/new_thread.ltxt
./messages/templates/messages/email/private_message.ltxt
./announcements/templates/announcements/email/announcement.ltxt

Bug #846386 covers the wiki ones.

Bumping this one out of the 2013.4 sprint and into 2013.5.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/kitsune/pull/1193

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/kitsune/commit/89a4e7375377c9410776a016dc7d66356504b6a2

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now!

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

This ended up being 2 points. I was able to reuse a bunch of code I wrote previously, the kbforums and forums templates were identical, and I didn't bump into anything unexpected.