BaselineCompiler: Compile iteration opcodes

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

(Blocks: 1 bug)

Other Branch
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Iteration opcodes --- JSOP_ITER, JSOP_ITERNEXT, JSOP_ENDITER, JSOP_MOREITER --- are compiled by JM but not by Baseline.  Initially these can all just be stubbed, though caches for at least ITERNEXT and MOREITER will probably be needed before long.
(Assignee)

Updated

5 years ago
Assignee: general → bhackett1024
(Assignee)

Comment 1

5 years ago
Created attachment 711479 [details] [diff] [review]
patch
Attachment #711479 - Flags: review?(kvijayan)

Updated

5 years ago
Attachment #711479 - Flags: review?(kvijayan) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/92621f184e4d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(In reply to Brian Hackett (:bhackett) from comment #0)
> Iteration opcodes --- JSOP_ITER, JSOP_ITERNEXT, JSOP_ENDITER, JSOP_MOREITER
> --- are compiled by JM but not by Baseline.  Initially these can all just be
> stubbed, though caches for at least ITERNEXT and MOREITER will probably be
> needed before long.

Good prediction.  We're 10x slower on string-fasta with BL+Ion compared to JM+Ion and this seems to be responsible for a significant chunk of that.
You need to log in before you can comment on or make changes to this bug.