Closed Bug 839172 Opened 9 years ago Closed 9 years ago

BaselineCompiler: Compile iteration opcodes

Categories

(Core :: JavaScript Engine, defect)

Other Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

Attachments

(1 file)

Iteration opcodes --- JSOP_ITER, JSOP_ITERNEXT, JSOP_ENDITER, JSOP_MOREITER --- are compiled by JM but not by Baseline.  Initially these can all just be stubbed, though caches for at least ITERNEXT and MOREITER will probably be needed before long.
Assignee: general → bhackett1024
Attached patch patchSplinter Review
Attachment #711479 - Flags: review?(kvijayan)
Attachment #711479 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/92621f184e4d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to Brian Hackett (:bhackett) from comment #0)
> Iteration opcodes --- JSOP_ITER, JSOP_ITERNEXT, JSOP_ENDITER, JSOP_MOREITER
> --- are compiled by JM but not by Baseline.  Initially these can all just be
> stubbed, though caches for at least ITERNEXT and MOREITER will probably be
> needed before long.

Good prediction.  We're 10x slower on string-fasta with BL+Ion compared to JM+Ion and this seems to be responsible for a significant chunk of that.
You need to log in before you can comment on or make changes to this bug.