Closed
Bug 839179
Opened 13 years ago
Closed 13 years ago
Move HTMLButtonElement to WebIDL
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
|
40.16 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
9.00 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
3.09 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
|
1.53 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #711432 -
Flags: review?(bzbarsky)
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #711433 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #711434 -
Flags: review?(mounir)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 711432 [details] [diff] [review]
Part a: Namespacing
r=me
Attachment #711432 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 711433 [details] [diff] [review]
Part b: Binding
r=me
Attachment #711433 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 711434 [details] [diff] [review]
Part c: A test
r=me, for what it's worth
|
|
Assignee | |
Comment 6•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1416061b8e7b
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd295f459224
https://hg.mozilla.org/integration/mozilla-inbound/rev/7357eb529db2
Flags: in-testsuite+
|
|
Assignee | |
Comment 7•13 years ago
|
||
Attachment #711813 -
Flags: review?(bzbarsky)
|
|
||
Comment 8•13 years ago
|
||
Comment on attachment 711813 [details] [diff] [review]
Part d: Throw as appropriate
Whoops. I should have caught that....
r=me
Attachment #711813 -
Flags: review?(bzbarsky) → review+
|
||
Comment 9•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1416061b8e7b
https://hg.mozilla.org/mozilla-central/rev/cd295f459224
https://hg.mozilla.org/mozilla-central/rev/7357eb529db2
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
|
Assignee | |
Comment 10•13 years ago
|
||
|
||
Comment 11•13 years ago
|
||
Comment on attachment 711434 [details] [diff] [review]
Part c: A test
Review of attachment 711434 [details] [diff] [review]:
-----------------------------------------------------------------
retro-active r+ ;)
Attachment #711434 -
Flags: review?(mounir) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•