839205 - If Firefox crashes after uninstalling a lightweight theme the theme is still present after restarting.

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Brian Nicholson (:bnicholson)]

STR:
1) Install a persona
2) Uninstall the persona
3) kill -9 firefox
4) Reopen Firefox

Expected result:
The persona is gone

Actual result:
The uninstalled persona is back

This doesn't happen for other add-ons. This bug is also reproducible on Fennec (which is where I found it). On Fennec, updating/reinstalling the APK can be used as step 3.

Comment 1

[Matthias Versen [:Matti]]

Why should the persona be back if you uninstall it ?
>This doesn't happen for other add-ons
Do you use restartless addons in your test ?

Comment 2

[Brian Nicholson (:bnicholson)]

(In reply to Matthias Versen [:Matti] from comment #1)
> Why should the persona be back if you uninstall it ?

I don't understand your question. The persona shouldn't be back, but it is (that's what this bug is about).

> >This doesn't happen for other add-ons
> Do you use restartless addons in your test ?

I just tested with PDF Viewer. After killing Firefox, the add-on is, in fact, still installed - though it's disabled. When testing the persona, it was not disabled after Firefox was killed. Either way, the add-ons were still installed in both cases, so it looks like restartless add-ons in general have this issue.

Comment 3

[Matthias Versen [:Matti]]

>I don't understand your question
Sorry, i confused Expected and Actual result.

Comment 4

[Dave Townsend [:mossop]]

I'm guessing this only happens if the add-ons manager is still open when you kill firefox?

Comment 5

[Brian Nicholson (:bnicholson)]

(In reply to Dave Townsend (:Mossop) from comment #4)
> I'm guessing this only happens if the add-ons manager is still open when you
> kill firefox?

Hm, maybe this is a largely a personas issue after all. For restartless add-ons, this only happens if Firefox is killed while the add-ons manager is open as you guessed. For personas, however, I can uninstall the persona, close out of the add-ons manager, kill Firefox, and have the persona still be installed (and applied!) when Firefox is reopened.

Comment 6

[Dave Townsend [:mossop]]

(In reply to Brian Nicholson (:bnicholson) from comment #5)
> (In reply to Dave Townsend (:Mossop) from comment #4)
> > I'm guessing this only happens if the add-ons manager is still open when you
> > kill firefox?
> 
> Hm, maybe this is a largely a personas issue after all. For restartless
> add-ons, this only happens if Firefox is killed while the add-ons manager is
> open as you guessed. For personas, however, I can uninstall the persona,
> close out of the add-ons manager, kill Firefox, and have the persona still
> be installed (and applied!) when Firefox is reopened.

Going to switch this back to a personas only bug then, bug 612168 will (hopefully) take care of the case for restartless add-ons.

For this we need to flush the prefs to disk after removing the persona.

Comment 7

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.