839244 - macros.py substitutes parameters wherever they appear, not only whole words

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Niko Matsakis [:nmatsakis]]

This macro:

    macro TRY_PARALLEL(m) = ((!m || m.mode === "par"));

applied to this input:

    TRY_PARALLEL(mode)

yields:

    ((!mode || mode.modeode === "par"))
                    ^^^^^^^

(Highlight mine)

I think it should behave like cpp and only substitute `m` if it appears as a whole word.  For the time being I have switched our macros to use UPPERCASE parameter names so as to make collisions less likely.

Comment 1

[Niko Matsakis [:nmatsakis]]

Sorry, by "our" macros, I meant the macros pertaining to ParallelArray.js