839256 - crash in mozilla::dom::TabChild::CachedFileDescriptorCallbackRunnable::~CachedFileDescriptorCallbackRunnable after trying to update Here maps

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: log cat

This bug was filed from the Socorro interface and is 
report bp-8c80893b-60d4-4383-89e7-954d82130207 .
============================================================= 
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/4518b78583d0
Gaia   7e54ca673277b20b1d91d18477dc44d6ad226761
BuildID 20130207070202
Version 18.0
Unagi

## Repro :
1. flash device
2. go through fte, set up wifi
3. go to settings, device info, select check now
4. pull down notification bar
5. update HERE

## Expected :
No crash

## Actual :
Crash occurs

## Note :

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

https://crash-stats.mozilla.com/report/index/657ae1b6-9933-49e1-b058-c8d2f2130207 was me retesting to verify that I can crash in this way.

Comment 2

[Robert Kaiser]

I wonder if https://crash-stats.mozilla.com/report/list?signature=mozilla%3A%3Adom%3A%3ATabChild%3A%3ACachedFileDescriptorCallbackRunnable%3A%3ARun is the same issue, the signature is almost identical, just that it's ::Run instead of the destructor.

Comment 3

[Marcia Knous [:marcia]]

Naoki: Isn't there a bug on file for the fact that we are offering a Maps update when there isn't one? That may be the reason why we are crashing. That bug had to do with a missing etag.

Comment 4

[Robert Kaiser]

"Missing ETag sounds" like a server-side thing. We shouldn't crash on the client-side because of a server-side bug.

Comment 5

[Marcia Knous [:marcia]]

I was able to reproduce this crash without any update operation using today's build: https://crash-stats.mozilla.com/report/index/cc8022e0-2991-45e8-bd02-96d722130208

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Marcia I believe you are talking about : bug 834903
there is also Bug 832565 

Neither talk about crashing.  I agree with Kairo.  We shouldn't be crashing and we should gracefully handle these situations.  Neither bug talks about crashing.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

(Need more coffee... maybe I won't repeat myself so often... )

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This trivially reproduces just launching the maps app.

Has the cause of this been backed out?

Comment 9

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

$ (cd gecko/ && git rev-parse HEAD && cd ../gaia && git rev-parse HEAD)
cb007bcbaaffacf2e8ea93a60cf7c4ccd1164437
9aab784d8e572853c79403334f4dac0f9c9c4678

Comment 10

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Looks like bug 835698 relanded.

bent, this crash is still reproducing, can you please fix or back out?

/me starts backout timer ;)

Comment 11

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Wait, still? This is crazy. Both jduell and I ran this a ton on our local builds. How is it we have no automated tests that show crashes in this code?

I'm on vacation until Thursday with sort of restricted access to internet (bugmail is about the max this crappy connection can do... I can't get an hg pull to succeed even) so if you need to back me out please do (with my apologies).

Comment 12

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Alright, need to back out then :(.

Comment 13

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Any debugging help would be greatly appreciated (since I've never seen this...)!

Comment 14

[Allen Maxwell]

Issue occurs on:

build: 20130213071150
Gecko:  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6fec2938ac1e
Gaia   07aa79239ced90a7ca0e8da8829fbcb330c42e9f

Comment 15

[Allen Maxwell]

Attachment: Crash report during reboot

Comment 16

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to Allen Maxwell from comment #14)
> Issue occurs on:
> 
> build: 20130213071150
> Gecko:  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6fec2938ac1e

Are you sure about the gecko revision?  It's from after bug 835698 was backed out again.

Comment 17

[Jason Duell]

I can't seem to reproduce this with the following steps, at least:

1) put |export B2G_UPDATE_CHANNEL=none| in .userconfig and reconfig/build
 -- this is to prevent having to take OS update along with maps update

2) flash

3) boot, wait a minute until "1 update avail" shows in pull-down.  Select it.

Update works for me fine (AFAICT: I don't see a way to check version # of app.  There's no crash at least).   I can also launch maps app fine, either before or after doing the update.

This is on Unagi phone using debug build of b2g18 with the lastest backout of this bug reapplied.

Comment 18

[Scoobidiver (away)]

Crashes stopped after 18.0/20130208070201.

Comment 19

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Scoobi is right.

Most of the recent crashes have to do with using an older version of the kernel (date on the OS should be Dec. 5th) and having an older build.  We need people on the latest stuff to verify that it's fixed for sure.

Comment 20

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I just relanded bug 835698, let's see if this comes back.

Comment 21

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(If it does, let's file a new bug.)