839265 - Build warning "RecordedEvent.cpp:885:12 [-Wswitch] enumeration value ‘OP_ARCTO’ not handled in switch" (or rather: OP_ARCTO is completely unused)

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning:
{
gfx/2d/RecordedEvent.cpp:885:12 [-Wswitch] enumeration value ‘OP_ARCTO’ not handled in switch
}

The switch statement in question is here:
https://mxr.mozilla.org/mozilla-central/source/gfx/2d/RecordedEvent.cpp#885
and it handles every type of OpType *except* for ARCTO.

It's been like this since this chunk (and the enum type) was added, in this cset:
 https://hg.mozilla.org/mozilla-central/rev/ed2e2da7d098

It actually looks like ARCTO is completely unused right now, as shown by this MXR search:
   https://mxr.mozilla.org/mozilla-central/search?string=OP_ARCTO
All of the other enum values have corresponding functions in PathRecording.cpp (e.g. PathBuilderRecording::MoveTo), but there's no such function for ARCTO.

I'm guessing OP_ARCTO was just cruft in the patch that added it, and it should just be dropped.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1: remove OP_ARCTO

Comment 2

[Daniel Holbert [:dholbert]]

(note: For some reason, I've received no bugmail for this bug, in the ~10 minutes since I filed it, though I have gotten bugmail for another bug that I filed afterwards. I wonder if I've hit a b.m.o bug of some sort)

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #2)
> (note: For some reason, I've received no bugmail for this bug, in the ~10
> minutes since I filed it

(filed bug 839277 on that; it seems to be fixed now)

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03f26f5e781c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/03f26f5e781c