Closed Bug 839265 Opened 8 years ago Closed 8 years ago

Build warning "RecordedEvent.cpp:885:12 [-Wswitch] enumeration value ‘OP_ARCTO’ not handled in switch" (or rather: OP_ARCTO is completely unused)

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Build warning:
{
gfx/2d/RecordedEvent.cpp:885:12 [-Wswitch] enumeration value ‘OP_ARCTO’ not handled in switch
}

The switch statement in question is here:
https://mxr.mozilla.org/mozilla-central/source/gfx/2d/RecordedEvent.cpp#885
and it handles every type of OpType *except* for ARCTO.

It's been like this since this chunk (and the enum type) was added, in this cset:
 https://hg.mozilla.org/mozilla-central/rev/ed2e2da7d098

It actually looks like ARCTO is completely unused right now, as shown by this MXR search:
   https://mxr.mozilla.org/mozilla-central/search?string=OP_ARCTO
All of the other enum values have corresponding functions in PathRecording.cpp (e.g. PathBuilderRecording::MoveTo), but there's no such function for ARCTO.

I'm guessing OP_ARCTO was just cruft in the patch that added it, and it should just be dropped.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #711527 - Flags: review?(bas)
Summary: RecordedEvent.cpp:885:12 [-Wswitch] enumeration value ‘OP_ARCTO’ not handled in switch (or: OP_ARCTO is completely unused) → Build warning "RecordedEvent.cpp:885:12 [-Wswitch] enumeration value ‘OP_ARCTO’ not handled in switch" (or rather: OP_ARCTO is completely unused)
Blocks: 839269
(note: For some reason, I've received no bugmail for this bug, in the ~10 minutes since I filed it, though I have gotten bugmail for another bug that I filed afterwards. I wonder if I've hit a b.m.o bug of some sort)
(In reply to Daniel Holbert [:dholbert] from comment #2)
> (note: For some reason, I've received no bugmail for this bug, in the ~10
> minutes since I filed it

(filed bug 839277 on that; it seems to be fixed now)
Attachment #711527 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/03f26f5e781c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.