Re-enable WebRTC when bug 837618 is fixed

RESOLVED FIXED in Thunderbird 24.0

Status

Thunderbird
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

13 Branch
Thunderbird 24.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Bug 839046 temporarily disabled WebRTC as a work around for bug 837618.

Once bug 837618 is fixed, we should re-enabled WebRTC as it is something extensions might want to use.

Note: when we re-enable, we need to do more than backing out bug 839046 - we need to add the required parts to packaging as well, as currently not everything is packaged that is needed for WebRTC.

Updated

4 years ago
Depends on: 841636
(Assignee)

Comment 1

4 years ago
Created attachment 765418 [details] [diff] [review]
The fix

This enables webrtc, and has the side effect of fixing the bustage on trunk.
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #765418 - Flags: review?(Pidgeot18)

Updated

4 years ago
Attachment #765418 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 2

4 years ago
https://hg.mozilla.org/comm-central/rev/ff64a366af33
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
Just a small headsup - this breaks packaging on platforms where webrtc is not enabled (ie the BSDs) because peerconnection files are not guarded within #ifdef MOZ_WEBRTC in mail/installer/package-manifest.in. Testing an obvious fix here, then will post a follwup patch for review.
Created attachment 766314 [details] [diff] [review]
Fix packaging when MOZ_WEBRTC is not defined

Fixes the issue here, thunderbird-24.0a1.en-US.openbsd5.3-x86_64.tar.bz2 is fine with that diff
Attachment #766314 - Flags: review?(mbanner)
(Assignee)

Updated

4 years ago
Attachment #766314 - Flags: review?(mbanner) → review+
(Assignee)

Comment 5

4 years ago
https://hg.mozilla.org/comm-central/rev/2592479ad475
You need to log in before you can comment on or make changes to this bug.