Closed Bug 839319 Opened 8 years ago Closed 8 years ago

Switch to WAVE_FORMAT_EXTENSIBLE for all formats in cubeb winmm backend

Categories

(Core :: Audio/Video, defect)

All
Windows 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(1 file)

While working on bug 837430, I discovered the WAVE_FORMAT_EXTENSIBLE path was broken because wValidBitsPerSample was not initialized correctly.. Once it was, it was clobbered by later zero-initializations of wSamplesPerBlock and wReserved, which are part of the same union.

With that fixed, WAVE_FORMAT_EXTENSIBLE works, so we might as well use it exclusively and remove a conditional.  This also enables multichannel audio to work with WinMM, but more work needs to be done (in bug 521615) to map Vorbis channel layouts to Wave channel layouts.
Attachment #711605 - Flags: review?(chris.double)
Attachment #711605 - Flags: review?(chris.double) → review+
https://hg.mozilla.org/mozilla-central/rev/0b521694bdbc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Depends on: 842176
You need to log in before you can comment on or make changes to this bug.