context-menu overflow menu can become completely hidden

RESOLVED FIXED

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
In some cases it is possible for the context menus to be in the overflow menu but the overflow menu itself is completely hidden so nothing is visible.
(Assignee)

Updated

4 years ago
Blocks: 839322
(Assignee)

Updated

4 years ago
Priority: -- → P1
(Assignee)

Comment 1

4 years ago
Probably easiest to just fix this as part of bug 839318
Depends on: 839318
(Assignee)

Comment 2

4 years ago
This happens if one add-ons menu items are all hidden (specifically the last module loaded)
(Assignee)

Comment 3

4 years ago
Created attachment 711638 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/775

Pointer to Github pull-request
(Assignee)

Updated

4 years ago
Attachment #711638 - Flags: review?(poirot.alex)
(Assignee)

Updated

4 years ago
Assignee: nobody → dtownsend+bugmail
No longer depends on: 839318
(Assignee)

Updated

4 years ago
Attachment #711638 - Flags: review?(poirot.alex) → review?(evold)

Comment 4

4 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1e8f44e52bd4efce28e81a11f25cc39113698f8c
Bug 839321: If a context-menu module's items are all hidden then it may hide the items from other add-ons.

https://github.com/mozilla/addon-sdk/commit/169194f78c8ae775fb76fe23cd050a171efc02cd
Merge pull request #775 from Mossop/bug839321

Fix Bug 839321: If a context-menu module's items are all hidden then it may hide the items from other add-ons r=@erikvold
Attachment #711638 - Flags: review?(evold) → review+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 5

4 years ago
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1dd5ece52cee3185aafd863eeb5c79a2949de02c
Bug 839321: If a context-menu module's items are all hidden then it may hide the items from other add-ons.
(cherry picked from commit 1e8f44e52bd4efce28e81a11f25cc39113698f8c)
You need to log in before you can comment on or make changes to this bug.