839325 - Cleanup in aisle GeckoViewsFactory

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

The table of things is really ugly, and the string compares probably aren't cheap when we're doing an average of 17.5 of them for every view.

Try run at https://tbpl.mozilla.org/?tree=Try&rev=13289444c45d for talos

Comment 1

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 711611 [details] [diff] [review]
Patch

Review of attachment 711611 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
How 17.5?
Why size /load-factor ?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

(In reply to Sriram Ramasubramanian [:sriram] from comment #1)
> How 17.5?

Sorry, that should be 18. It'll do between 1 and 35 string compares. Since they're not ordered by frequency, assuming each one is hit once, that averages out to 18 string compares per call.

> Why size /load-factor ?

Because if the number of elements put into the hashtable is more than (capacity * load-factor) then the hashtable does an expensive resize operation to make itself bigger. If we know how many elements are going into it ahead of time, it's best to just size the hashtable correctly the first time.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffd1feb1a4c0

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ffd1feb1a4c0