839344 - Increase Demo Studio / Dev Derby upload limit

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Demo Studio / Dev Derby, defect)

Description

[John Karahalis [:openjck]]

What feature should be changed? Please provide the URL of the feature if possible.
==================================================================================
The upload limit used on the Demo Studio and the Dev Derby. The new limit should be at least double the current limit to be sure it is relatively future-proof.

What problems would this solve?
===============================
A few users are hitting the limit, most notably the people behind BananaBread, probably the most important demo on the site.

Who would use this?
===================
Anyone who submits to the Derby, but particularly the authors of BananaBread and (in the future) apps authors.

What would users see?
=====================
N/A.

What would users do? What would happen as a result?
===================================================
Users would be able to upload demos roughly twice as big.

Is there anything else we should know?
======================================

Comment 1

[Les Orchard [:lorchard]]

In order to accommodate this, we really need offline processing of demo .zip files in a queue (bug 632082) so that the submitting user isn't made to wait (and potentially time out) while the upload is processed.

Comment 2

[Les Orchard [:lorchard]]

On the other hand, we can try just bumping the limit up and see if anyone really runs into an issue. Switching to an async/offline demo upload processing model will be somewhat involved.

Comment 3

[John Karahalis [:openjck]]

Yeah. The goal here is to have a temporary solution. Offline processing and Git submission will solve the underlying problem.

Comment 4

[Les Orchard [:lorchard]]

FWIW, here's where the settings are defined, which require an IT bug to change:

https://github.com/mozilla/kuma/blob/master/apps/demos/models.py#L67

* DEMO_MAX_ZIP_FILESIZE
    * Maximum size accepted for a .zip overall

* DEMO_MAX_FILESIZE_IN_ZIP
    * Maximum size accepted for any given file contained in the .zip after decompression (though I think this looks for what the .zip lists in its table of contents, and doesn't do a real decompression first)

Comment 5

[John Karahalis [:openjck]]

Doing the Design phase myself here. This should not have any real impact on design, other than allowing users to submit larger demos.

This might cause a timeout for very large demos (see comment 1) but this is an acceptable tradeoff as we need to increase this limit as soon as possible and the timeout will be seen by very few users if any. The underlying problem will be resolved when we process uploads offline.

Les: I am going to call this done for design, and also mark this "Ready" in the "Technical Research" column based on comment 4.

Comment 6

[Les Orchard [:lorchard]]

Filed IT bug 840149 to add settings to increase the upload limit. This won't result in a pull request to review, and so will skip straight to Released once the IT bug is closed.

Comment 7

[John Karahalis [:openjck]]

Bug 840149 is closed.

Comment 8

[Les Orchard [:lorchard]]

(In reply to John Karahalis [:openjck] from comment #7)
> Bug 840149 is closed.

Well, yeah, but I haven't had a chance to try this out on prod yet :)

Comment 9

[Les Orchard [:lorchard]]

(that is, wait until I've verified:fixed the IT bug)

Comment 10

[Les Orchard [:lorchard]]

Ack, sorry about the quick reopen / close. I was in the middle of verifying and it was looking like it was going to timeout and give me an error. But, it looks like the upload went through after about 3 minutes of spinning.

Comment 11

[Les Orchard [:lorchard]]

Going to call this verified too, since I just did so myself.