B2G SMS & B2G MMS: clean up the chaotic terminology for |record| and |message| in MobileMessageDatabaseService.js

RESOLVED FIXED in Firefox 21

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Gene Lian (I already quit Mozilla), Assigned: Gene Lian (I already quit Mozilla))

Tracking

(Blocks: 3 bugs)

Trunk
mozilla21
Points:
---
Dependency tree / graph
Bug Flags:
in-moztrap -

Firefox Tracking Flags

(blocking-b2g:leo+, firefox20 wontfix, firefox21 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
The terminology is a chaos. Sometimes we use |message|, |record| and |data| to refer to the same thing but they actually have different meanings. I hope to clean them up first so that it's easier to do the following tasks for constructing the MMS database.
(Assignee)

Comment 1

5 years ago
Created attachment 711659 [details] [diff] [review]
Patch
Attachment #711659 - Flags: review?(mounir)
(Assignee)

Comment 2

5 years ago
Created attachment 711666 [details] [diff] [review]
Patch, V1.1
Attachment #711659 - Attachment is obsolete: true
Attachment #711659 - Flags: review?(mounir)
Attachment #711666 - Flags: review?(mounir)
Comment on attachment 711666 [details] [diff] [review]
Patch, V1.1

Review of attachment 711666 [details] [diff] [review]:
-----------------------------------------------------------------

r=me instead.
Attachment #711666 - Flags: review?(mounir) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/80dcbc0b99e0
(Assignee)

Updated

5 years ago
Blocks: 839436
https://hg.mozilla.org/mozilla-central/rev/80dcbc0b99e0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
(Assignee)

Comment 6

5 years ago
This bug relates to MMS features and needs to be tagged as leo+ so that we can uplift it into the b2g-18 branch.
blocking-b2g: --- → leo?
Leo triage: leo+ for MMS blockers
blocking-b2g: leo? → leo+
unable to find 'dom/mobilemessage/src/ril/MobileMessageDatabaseService.js' for patching
14 out of 14 hunks FAILED -- saving rejects to file dom/mobilemessage/src/ril/MobileMessageDatabaseService.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 839352
(Assignee)

Comment 9

5 years ago
This one depends on Bug 831683, which needs to be checked in first.
Depends on: 831683
(Assignee)

Comment 10

5 years ago
https://hg.mozilla.org/releases/mozilla-b2g18/rev/ea3d5929ec68
status-b2g18: --- → fixed
status-firefox21: --- → fixed
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → wontfix
status-firefox20: --- → wontfix
Blocks: 833291

Updated

4 years ago
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.