Closed Bug 839352 Opened 7 years ago Closed 7 years ago

B2G SMS & B2G MMS: clean up the chaotic terminology for |record| and |message| in MobileMessageDatabaseService.js

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21
blocking-b2g leo+
Tracking Status
firefox20 --- wontfix
firefox21 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix

People

(Reporter: airpingu, Assigned: airpingu)

References

Details

Attachments

(1 file, 1 obsolete file)

The terminology is a chaos. Sometimes we use |message|, |record| and |data| to refer to the same thing but they actually have different meanings. I hope to clean them up first so that it's easier to do the following tasks for constructing the MMS database.
Attached patch Patch (obsolete) — Splinter Review
Attachment #711659 - Flags: review?(mounir)
Attached patch Patch, V1.1Splinter Review
Attachment #711659 - Attachment is obsolete: true
Attachment #711659 - Flags: review?(mounir)
Attachment #711666 - Flags: review?(mounir)
Comment on attachment 711666 [details] [diff] [review]
Patch, V1.1

Review of attachment 711666 [details] [diff] [review]:
-----------------------------------------------------------------

r=me instead.
Attachment #711666 - Flags: review?(mounir) → review+
Blocks: 839436
https://hg.mozilla.org/mozilla-central/rev/80dcbc0b99e0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
This bug relates to MMS features and needs to be tagged as leo+ so that we can uplift it into the b2g-18 branch.
blocking-b2g: --- → leo?
Leo triage: leo+ for MMS blockers
blocking-b2g: leo? → leo+
unable to find 'dom/mobilemessage/src/ril/MobileMessageDatabaseService.js' for patching
14 out of 14 hunks FAILED -- saving rejects to file dom/mobilemessage/src/ril/MobileMessageDatabaseService.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 839352
This one depends on Bug 831683, which needs to be checked in first.
Depends on: 831683
Flags: in-moztrap-
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.