Closed Bug 839393 Opened 7 years ago Closed 7 years ago

Opt build warning: DASHDecoder.cpp:993:8: warning: unused variable 'noRepAvailable' [-Wunused-variable]

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED WONTFIX

People

(Reporter: dholbert, Unassigned)

References

(Blocks 1 open bug)

Details

Build warning:
{
content/media/dash/DASHDecoder.cpp:993:8: warning: unused variable 'noRepAvailable' [-Wunused-variable]
}

992   uint32_t bestRepIdx = UINT32_MAX;
993   bool noRepAvailable = !mMPDManager->GetBestRepForBandwidth(mVideoAdaptSetIdx,
994                                                              downloadRate,
995                                                              bestRepIdx);
996   LOG("downloadRate [%0.2f kbps] reliable [%s] bestRepIdx [%d] noRepAvailable [%s]",
997       downloadRate/1000.0, (reliable ? "yes" : "no"), bestRepIdx,
998       (noRepAvailable ? "yes" : "no"));
999 
1000   // If there is a higher bitrate stream that can be downloaded with the
1001   // current estimated bandwidth, step up to the next stream, for a graceful
1002   // increase in quality.
1003   uint32_t toDecoderIdx = mVideoRepDecoderIdx;
1004   if (bestRepIdx > toDecoderIdx) {
1005     toDecoderIdx = std::min(toDecoderIdx+1, mVideoRepDecoders.Length()-1);
1006   } else if (toDecoderIdx < bestRepIdx) {
1007     // If the bitrate is too much for the current bandwidth, just use that
1008     // stream directly.
1009     toDecoderIdx = bestRepIdx;
1010   }

Looks like we maybe should be checking this variable... (probably before we use the value of bestRepIdx)?
Blocks: buildwarning
Summary: Opt build warning: → Opt build warning: DASHDecoder.cpp:993:8: warning: unused variable 'noRepAvailable' [-Wunused-variable]
Daniel - thanks for reporting this and sorry for taking so long to comment.
DASH work in Gecko has been halted indefinitely (see Bug 702122 comment 10), so I'm going to mark this as wontfix.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.