839400 - Design a way to navigate between Reviewer Tools for apps, add-ons and themes

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P4)

Description

[Bram Pitoyo [:bram]]

Attachment: switching between reviewer tools - 01

Currently, we have three different Reviewer Tools for apps (Marketplace), themes (Persona) and add-ons. Someday, the plan is to merge the content of all three into one Marketplace. This is the bug to figure out how to navigate between these three reviewer tools, so contributors can help in more than one place.

Attached is a first pass at some navigation tools. More to come.

Comment 1

[Andrew Williamson [:eviljeff]]

I'd go for 1 or 2.  Though I think it also depends on what we want to do with https://marketplace.firefox.com/reviewers/ and whether we want to conceptualise the three different types as entirely separate tools.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

I also like 1 or 2, in that order.

Comment 3

[Amy Tsay [:amyt]]

The links on #2 stands out more to me. One thing missing is the new Reviewer Leaderboard link...might be a good opportunity to explore whether this is the best placement for it. http://imgur.com/7iKC0qx

Comment 4

[Bram Pitoyo [:bram]]

After talking with Adora for a bit, I feel that trying to navigate between the three reviewer tools is more of a technical convenience. “Technical convenience” means that it’s something that benefits Mozilla staffs, admins, and my tendency to see everything organize properly.

It’s more about that, rather than wins for user, because I had assumed that that our volunteer reviewers are working in silos—which is not necessarily a bad thing. This means that those who are reviewing plugins don’t tend to review themes, those who review apps don’t tend to review plugins, and so on. So providing a link between the three tools seems superfluous.

And now that I think about the consequence more, if the Reviewer Tools are joined, there might be an implicit pressure to merge AMO and Marketplace on the consumer and the developer sides, which is opening cans and cans of worms and making me cower in terror.

I might be over-thinking. The fact is that we still have three different tools that does many of the same things, located across three different URLs. So we should keep talking about this: discussing the positives and the negatives. So when the integration happen, the Reviewer Tools are ready to be linked together with a solution that we’ve discussed before.

Comment 5

[Andrew Williamson [:eviljeff]]

(In reply to Bram Pitoyo [:bram] from comment #4)
> After talking with Adora for a bit, I feel that trying to navigate between
> the three reviewer tools is more of a technical convenience. “Technical
> convenience” means that it’s something that benefits Mozilla staffs, admins,
> and my tendency to see everything organize properly.

I'm not sure why a technical convenience is a bad thing?  Mozilla staff are the biggest single users of Marketplace.

> It’s more about that, rather than wins for user, because I had assumed that
> that our volunteer reviewers are working in silos—which is not necessarily a
> bad thing. This means that those who are reviewing plugins don’t tend to
> review themes, those who review apps don’t tend to review plugins, and so
> on. So providing a link between the three tools seems superfluous.

it may not be the norm, but I expect it will happen occasionally.

> And now that I think about the consequence more, if the Reviewer Tools are
> joined, there might be an implicit pressure to merge AMO and Marketplace on
> the consumer and the developer sides, which is opening cans and cans of
> worms and making me cower in terror.

I don't mean to give you nightmares Bram, but the merge IS happening.  For Themes soon.  I really doubt this will change the speed of the future AMO merge.

> I might be over-thinking. The fact is that we still have three different
> tools that does many of the same things, located across three different
> URLs. So we should keep talking about this: discussing the positives and the
> negatives. So when the integration happen, the Reviewer Tools are ready to
> be linked together with a solution that we’ve discussed before.

Sorry, I'm still unclear what has changed since comment #0 as everything you wrote there is perfectly valid.  What /are/ the negatives of adding a few links?

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

Yeah, I don't get that, either.

I also assumed that you would only see the links if you're on more than one of the reviewer groups. Maybe that reduces some of the pressure you're talking about? Either way, at least the theme migration is happening soon, so that isn't really a concern.

Comment 7

[Kris Maglione [:kmag]]

(In reply to Andrew Williamson [:eviljeff] from comment #5)
> > It’s more about that, rather than wins for user, because I had assumed that
> > that our volunteer reviewers are working in silos—which is not necessarily a
> > bad thing. This means that those who are reviewing plugins don’t tend to
> > review themes, those who review apps don’t tend to review plugins, and so
> > on. So providing a link between the three tools seems superfluous.
> 
> it may not be the norm, but I expect it will happen occasionally.

I hope that there will be considerable overlap between add-on 
and app reviewers in the future. Probably not so much with theme 
reviewers, but meh. The reason there's little overlap now is 
that Andrew and Lisa are essentially the only app reviewers at 
present.

> > And now that I think about the consequence more, if the Reviewer Tools are
> > joined, there might be an implicit pressure to merge AMO and Marketplace on
> > the consumer and the developer sides, which is opening cans and cans of
> > worms and making me cower in terror.
> 
> I don't mean to give you nightmares Bram, but the merge IS happening.  For
> Themes soon.  I really doubt this will change the speed of the future AMO
> merge.

It's not as though we haven't been talking about a merge since 
the beginning. No-one wants to have to continue maintaining AMO 
and Marketplace as two separate sites.

Comment 8

[Kris Maglione [:kmag]]

(Also, #2 is my favorite)

Comment 9

[Bram Pitoyo [:bram]]

Attachment: switching between reviewer tools - 02

I spent the day trying to see if the design of the Add-ons reviewer tool could be integrated into Apps and Themes tools (which currently shares the same design). It can (and all three tools share the same codebase, anyway), so it makes sense visually.

Next, I looked at how the navigation would work functionally. I like Jorge’s idea:

(In reply to Jorge Villalobos [:jorgev] from comment #6)
> I also assumed that you would only see the links if you're on more than one
> of the reviewer groups.

So then, I think that we can do something like this:
* When user has permission for one reviewer tool, hide the switcher
* When user has permission for two tools, only show the items user is allowed to access

By doing this, 1) there’s no way for user to get to the wrong place, and 2) those who are used to reviewing in one tool won’t have to see the switcher.


The mockup attached here is based on design option #2, but we can easily adapt option #1 if we like that instead. The only difference between this version and the last is that the switcher is located on the right-hand side, to the left of the gear menu.

Comment 10

[Amy Tsay [:amyt]]

I like.

Comment 11

[Andrew Williamson [:eviljeff]]

Removing Bram as assignee as he's done the UX work.  Now it just needs implementing.

Comment 12

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/pull/932

Comment 13

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/pull/932

Comment 14

[krupa raj[:krupa]]

There is a way to switch between Apps and Themes now. Add-ons are not included since they don't live on marketplace.