Port bug 830594 - Turn on ENABLE_SHARED_JS on Win64 builder for PGO linker limit

RESOLVED FIXED in Thunderbird 21.0

Status

MailNews Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 21.0
x86_64
Windows 8

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #830594 +++

I turned off ENABLE_SHARED_JS on Bin64 builder by bug 633465.  Actually, Win64 builder uses 32-bit linker due to https://connect.microsoft.com/VisualStudio/feedback/details/686117, but PGO linker seems to be 4GB limit. So nightly and pgo build cannot be built on builtbot due to ICE.
Created attachment 711732 [details] [diff] [review]
The fix

We need this to un-bust our Win64 bit builds - where I think the bustage is caused by the now different default setting of ENABLE_SHARED_JS.
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #711732 - Flags: review?(bugspam.Callek)
Comment on attachment 711732 [details] [diff] [review]
The fix

assuming this patch is against c-c not m-c, rs+=me, Win64 is (imho) also unsupported, so I don't care to think on this long, so long as it also doesn't break other builds (which this wont)

If its a m-c patch, please treat my rs+ as f+ and get a real peer to review.
Attachment #711732 - Flags: review?(bugspam.Callek) → review+
https://hg.mozilla.org/comm-central/rev/a9077e1863b5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Summary: Turn on ENABLE_SHARED_JS on Win64 builder for PGO linker limit → Port bug 830594 - Turn on ENABLE_SHARED_JS on Win64 builder for PGO linker limit
Target Milestone: --- → Thunderbird 21.0
You need to log in before you can comment on or make changes to this bug.