839413 - Port bug 830594 - Turn on ENABLE_SHARED_JS on Win64 builder for PGO linker limit

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Mark Banner (:standard8)]

+++ This bug was initially created as a clone of Bug #830594 +++

I turned off ENABLE_SHARED_JS on Bin64 builder by bug 633465.  Actually, Win64 builder uses 32-bit linker due to https://connect.microsoft.com/VisualStudio/feedback/details/686117, but PGO linker seems to be 4GB limit. So nightly and pgo build cannot be built on builtbot due to ICE.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

We need this to un-bust our Win64 bit builds - where I think the bustage is caused by the now different default setting of ENABLE_SHARED_JS.

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 711732 [details] [diff] [review]
The fix

assuming this patch is against c-c not m-c, rs+=me, Win64 is (imho) also unsupported, so I don't care to think on this long, so long as it also doesn't break other builds (which this wont)

If its a m-c patch, please treat my rs+ as f+ and get a real peer to review.

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/a9077e1863b5