839448 - [traceback] resendconfirmation kicking up keyerror

Status: RESOLVED FIXED

(support.mozilla.org :: Users and Groups, task, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

https://errormill.mozilla.org/support/group/14791/

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "session_csrf/__init__.py", line 127, in wrapper
    response = f(request, *args, **kw)
  File "mobility/decorators.py", line 23, in wrapper
    return f(request, *args, **kw)
  File "users/views.py", line 212, in resend_confirmation
    email_kwargs)
  File "django/template/loader.py", line 169, in render_to_string
    t = get_template(template_name)
  File "django/template/loader.py", line 145, in get_template
    template, origin = find_template(template_name)
  File "django/template/loader.py", line 134, in find_template
    source, display_name = loader(name, dirs)
  File "django/template/loader.py", line 42, in __call__
    return self.load_template(template_name, template_dirs)
  File "django/template/loader.py", line 48, in load_template
    template = get_template_from_string(source, origin, template_name)
  File "django/template/loader.py", line 156, in get_template_from_string
    return Template(source, origin, name)
  File "django/template/base.py", line 125, in __init__
    self.nodelist = compile_string(template_string, origin)
  File "django/template/base.py", line 153, in compile_string
    return parser.parse()
  File "django/template/base.py", line 246, in parse
    filter_expression = self.compile_filter(token.contents)
  File "django/template/base.py", line 346, in compile_filter
    return FilterExpression(token, self)
  File "django/template/base.py", line 557, in __init__
    filter_func = parser.find_filter(filter_name)
  File "django/template/base.py", line 352, in find_filter
    raise TemplateSyntaxError("Invalid filter: '%s'" % filter_name)


This is going through Django email template rendering code. Looks like I missed a path.

Making this a P1 for this sprint. It needs to get fixed pronto.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a pull request: https://github.com/mozilla/kitsune/pull/1134

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/kitsune/commit/75cce6cb33f07c12e41737e11d545c64744b9703

Pushed to production just now. I'm going to mark it fixed and watch sentry for additional instances of it. If it pops up again, I'll reopen.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

This ended up being a 1 point bug. Marking it as such.