Closed Bug 839465 Opened 7 years ago Closed 7 years ago

Implement SmartCardEvent using event code generator

Categories

(Core Graveyard :: Security: UI, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla21

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(2 files)

Patch coming.

(I'm not sure if we need SmartCardEvents still, but if we want to remove them, 
we can do that in a different bug.)
Attached patch patchSplinter Review
Only tests for SmardCardEvent creation in JS, but don't know to test
nsNSSComponent::DispatchEventToWindow handling.
It should work :) But please review changes to that method carefully.

https://tbpl.mozilla.org/?tree=Try&rev=2280e92ec135

The event was originally implemented in Bug 284366.
Attachment #711818 - Flags: review?(jst)
Attachment #711818 - Flags: feedback?(rrelyea)
Comment on attachment 711818 [details] [diff] [review]
patch

f+ this just looks like mozilla plumbing changes. the Smart card Monitor thread hasn't changes, which is the kind of changes I would need to look at closely.

I'm ok with these as long as they are following current mozilla event coding practices.

bob
Attachment #711818 - Flags: feedback?(rrelyea) → feedback+
Yes. The changes are need to make WebIDL bindings for events easier to implement.
Comment on attachment 711818 [details] [diff] [review]
patch

mounir might travel less in the next few days.
Attachment #711818 - Flags: review?(jst) → review?(mounir)
Comment on attachment 711818 [details] [diff] [review]
patch

Review of attachment 711818 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/test/test_eventctors.html
@@ +576,5 @@
> +ok(e.type, "hello", "SmartCardEvent: Wrong event type!");
> +ok(!e.isTrusted, "SmartCardEvent: Event shouldn't be trusted!");
> +ok(!e.bubbles, "SmartCardEvent: Event shouldn't bubble!");
> +ok(!e.cancelable, "SmartCardEvent: Event shouldn't be cancelable!");
> +ok(!e.tokenName);

is(e.tokenName, null);
Attachment #711818 - Flags: review?(mounir) → review+
Attached patch patchSplinter Review
https://hg.mozilla.org/mozilla-central/rev/dcf53b7140cd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.