839465 - Implement SmartCardEvent using event code generator

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Patch coming.

(I'm not sure if we need SmartCardEvents still, but if we want to remove them, 
we can do that in a different bug.)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Only tests for SmardCardEvent creation in JS, but don't know to test
nsNSSComponent::DispatchEventToWindow handling.
It should work :) But please review changes to that method carefully.

https://tbpl.mozilla.org/?tree=Try&rev=2280e92ec135

The event was originally implemented in Bug 284366.

Comment 2

[Robert Relyea]

Comment on attachment 711818 [details] [diff] [review]
patch

f+ this just looks like mozilla plumbing changes. the Smart card Monitor thread hasn't changes, which is the kind of changes I would need to look at closely.

I'm ok with these as long as they are following current mozilla event coding practices.

bob

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Yes. The changes are need to make WebIDL bindings for events easier to implement.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 711818 [details] [diff] [review]
patch

mounir might travel less in the next few days.

Comment 5

[Mounir Lamouri (:mounir)]

Comment on attachment 711818 [details] [diff] [review]
patch

Review of attachment 711818 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/test/test_eventctors.html
@@ +576,5 @@
> +ok(e.type, "hello", "SmartCardEvent: Wrong event type!");
> +ok(!e.isTrusted, "SmartCardEvent: Event shouldn't be trusted!");
> +ok(!e.bubbles, "SmartCardEvent: Event shouldn't bubble!");
> +ok(!e.cancelable, "SmartCardEvent: Event shouldn't be cancelable!");
> +ok(!e.tokenName);

is(e.tokenName, null);

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/dcf53b7140cd