Closed Bug 839529 Opened 7 years ago Closed 7 years ago

Remove various CC participants that don't do anything

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
No description provided.
Attachment #711867 - Flags: review?(bugs)
Attachment #711867 - Flags: review?(bugs) → review+
Comment on attachment 711867 [details] [diff] [review]
v1

Review of attachment 711867 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDOMFile.cpp
@@ +454,5 @@
>  // nsDOMFileCC implementation
>  
> +NS_IMPL_CYCLE_COLLECTION_UNLINK_0(nsDOMFileCC)
> +NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN(nsDOMFileCC)
> +  // We don't have anything to traverse, but some of our subclasses do.

Always nice when weirdness is explained!

::: xpcom/glue/nsCycleCollectionParticipant.h
@@ -793,5 @@
>      tmp->_unroot_function();                                                   \
>      return NS_OK;                                                              \
>    }
>  
> -#define NS_IMPL_CYCLE_COLLECTION_0(_class)                                     \

Maybe add a comment about why we don't define this, targeted at somebody who is writing a cycle collected class?  Though maybe most people don't read these headers and just copy from other places.
https://hg.mozilla.org/mozilla-central/rev/159954333c5e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.