Closed Bug 839587 Opened 11 years ago Closed 5 years ago

Move autogenerated jni stubs into a separate .so

Categories

(Firefox for Android Graveyard :: General, defect, P5)

All
Android
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: kats, Unassigned)

References

Details

Bug 794982 added some code to autogenerate the JNI stubs that mozglue uses to lazy-bind the implementations in libxul. However because of the build system ordering, it requires a copy of the autogenerated file to be checked in and kept-up-date as necessary (the build will fail when it changes, and requires copying the new version over).

To solve this problem, blassey suggested creating a separate .so file with the autogenerated stubs in mobile/android, and then linking that with libmozglue at the end of the build. We also discussed a bunch of other options but none of them work and so this seems to be the most viable approach. Note that the loadGeckoLibs function from APKOpen.cpp would also have to be moved into the new .so file.
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
Priority: -- → P5
We've gone in a wildly different direction, building JNI stubs into libxul directly.  We're not going to do this at this time.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.