839596 - BaselineCompiler: Add optimized string concatenation stub.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Kannan Vijayan [:djvj]]

ss date-format-xparb is hitting this a lot.

Comment 1

[Kannan Vijayan [:djvj]]

Attachment: Patch.

This brings us down to about 1.3x slower than JM+Ion on SS.

Comment 2

[Tom S [:evilpie]]

Comment on attachment 711966 [details] [diff] [review]
Patch.

Review of attachment 711966 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/BaselineIC.h
@@ +308,5 @@
>                                  \
>      _(BinaryArith_Fallback)     \
>      _(BinaryArith_Int32)        \
>      _(BinaryArith_Double)       \
> +    _(BinaryArith_Strcat)       \

We should try to avoid ugly names like that. StringConcat or Concat, like Ion.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 711966 [details] [diff] [review]
Patch.

Review of attachment 711966 [details] [diff] [review]:
-----------------------------------------------------------------

Cool. I agree with the StringConcat/Concat suggestion in comment 2 though.

Comment 4

[Kannan Vijayan [:djvj]]

(In reply to Tom Schuster [:evilpie] from comment #2)
> Comment on attachment 711966 [details] [diff] [review]
> Patch.
> 
> Review of attachment 711966 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/ion/BaselineIC.h
> @@ +308,5 @@
> >                                  \
> >      _(BinaryArith_Fallback)     \
> >      _(BinaryArith_Int32)        \
> >      _(BinaryArith_Double)       \
> > +    _(BinaryArith_Strcat)       \
> 
> We should try to avoid ugly names like that. StringConcat or Concat, like
> Ion.

Advice taken :)  Although I wouldn't call "strcat" ugly.. it's just beautiful in it's own way ;)

Comment 5

[Kannan Vijayan [:djvj]]

https://hg.mozilla.org/projects/ionmonkey/rev/f8b4d5891a15