839751 - "Assertion failure: i < argc_" with localeCompare

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

Attachment: browser testcase

Assertion failure: i < argc_, at jsapi.h:741

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Jeff Walden [:Waldo]]

Something's whacked, because the operator[] there is clearly guarded by args.length() > 0.  I can't reproduce this in a shell, and I see no reason why shell would behave differently from browser for this.

Comment 3

[Norbert Lindenberg]

I overlooked the assignment
   args[0].setString(thatStr);
which is only reached if an embedder (such as the browser) installs a callback. I don't see a reason for this assignment to exist - maybe it was a pre-RootedString attempt at rooting thatStr?

A different puzzle - how are we even getting here? The String constructor isn't supposed to have a localeCompare property - is that yet another wacko extension?

Comment 4

[Norbert Lindenberg]

Attachment: patch

Removed the statement that caused the assertion to fail.

Comment 5

[Jeff Walden [:Waldo]]

Comment on attachment 712161 [details] [diff] [review]
patch

Review of attachment 712161 [details] [diff] [review]:
-----------------------------------------------------------------

Sigh.  |args[n]| shouldn't be mutable.  :-(

Comment 6

[Jeff Walden [:Waldo]]

Comment on attachment 712161 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b379cdbf900

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7b379cdbf900