Starting with Daily 2013-02-09-030514 only the first conversation is shown. All additional conversations are working but not accessible (receiving direct messages is shown on chat button but not readable). Last good is 2013-02-08-030501 In console I see this: Sun Feb 10 2013 14:17:34 Error: aContactA.displayName is undefined Source file: chrome://messenger/content/chat/imgroup.xml Line: 39
Do we know what was checked in between these 2 nightlies that could cause the regression?
On c-c I see only https://hg.mozilla.org/comm-central/rev/76972e8b8432 but this is unlikely the cause. m-c has a lot: http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2013-02-08+03%3A05%3A01&enddate=2013-02-09+03%3A05%3A14
I tried to mark this blocking bug 821850, but apparently it's not possible without being allowed to access the bug :-(.
Comment on attachment 713308 [details] [diff] [review] Patch This seems like an annoying change, do we think this bites us anywhere else? Would be nice if an error was thrown in the console.
Cc'ing Bobby Holley who's the author of http://hg.mozilla.org/mozilla-central/rev/5264dc88e9c2 Bobby, I would just like to ensure that you are aware of the regressions that your changeset causes (I can't mark this bug as blocking bug 821850 myself). I suspect making the XBL methods readonly has the potential for breaking lots of add-ons. For example I expect lots of tab browsing add-ons to mess with methods of tabbrowser.xml. Is there any plan to mitigate this? If not I think the changes should at least be very clearly documented to add-on authors.
(In reply to Florian Quèze [:florian] [:flo] from comment #6) > I suspect making the XBL methods readonly has the potential for breaking > lots of add-ons. For example I expect lots of tab browsing add-ons to mess > with methods of tabbrowser.xml. Indeed even NoScript does it to patch the notification bar stuff in order to display notifications on the bottom, and to implement "sticky" menus. If these cases are doomed under the new rules, couldn't we just apply this restriction to non-privileged callers?
Florian, I didn't see a checkin of your patch. But the symptoms of this bug seems to have disappeared using a tinderbox build: http://hg.mozilla.org/mozilla-central/rev/7bd555e2acfa The only thing that I can guess at is that backout: https://hg.mozilla.org/comm-central/rev/0879e29b38b9 was the real issue all along.
Correct, it's working again also with 0215 Daily. It wasn't this backout because it was after Daily creation.
(In reply to Richard Marti [:Paenglab] from comment #9) > Correct, it's working again also with 0215 Daily. It wasn't this backout > because it was after Daily creation. Yeah, I fixed this in bug 839792.