Closed Bug 839911 Opened 7 years ago Closed 6 years ago

Separate animation out from layer code

Categories

(Firefox OS Graveyard :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ajones, Assigned: ajones)

References

Details

Attachments

(2 files, 2 obsolete files)

No description provided.
Attachment #712281 - Attachment description: Added a Forever() time period → Part 1: Added a Forever() time period
Attachment #712280 - Attachment description: Separate animation out from layer code → Part 2: Separate animation out from layer code
Attachment #8338237 - Flags: review?(bugmail.mozilla)
Attachment #8338237 - Attachment is obsolete: true
Attachment #8338237 - Flags: review?(bugmail.mozilla)
Should one of the attachments be obsolete here?
Attachment #712280 - Attachment is obsolete: true
Comment on attachment 8340841 [details] [diff] [review]
Separate animation out from layer code;

Review of attachment 8340841 [details] [diff] [review]:
-----------------------------------------------------------------

You need to remove DoFling from AsyncPanZoomController.h also.

::: gfx/layers/ipc/AsyncPanZoomController.cpp
@@ +1311,5 @@
> +        RequestContentRepaint();
> +      }
> +    } else {
> +      // Bring the resolution back in sync with the zoom, in case we scaled down
> +      // the zoom while accelerating.

Move this comment down a couple of lines, or just remove it entirely. It makes sense that we want to do a RequestContentRepaint after the animation is over.

::: gfx/layers/ipc/AsyncPanZoomController.h
@@ +720,5 @@
> +
> +  virtual bool Sample(FrameMetrics& aFrameMetrics,
> +                      const TimeDuration& aDelta) = 0;
> +
> +  TimeDuration mRepaintTime;

Rename this to mRepaintInterval, and change the constructor arg accordingly. Also add a comment on this class giving a quick summary of what it's for.
Attachment #8340841 - Flags: review?(bugmail.mozilla) → review+
You need to log in before you can comment on or make changes to this bug.