Closed
Bug 839911
Opened 11 years ago
Closed 10 years ago
Separate animation out from layer code
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ajones, Assigned: ajones)
References
Details
Attachments
(2 files, 2 obsolete files)
1.74 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
18.76 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #712281 -
Flags: review?(roc)
Assignee | ||
Updated•11 years ago
|
Attachment #712281 -
Attachment description: Added a Forever() time period → Part 1: Added a Forever() time period
Assignee | ||
Updated•11 years ago
|
Attachment #712280 -
Attachment description: Separate animation out from layer code → Part 2: Separate animation out from layer code
Attachment #712281 -
Flags: review?(roc) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8338237 -
Flags: review?(bugmail.mozilla)
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8340841 -
Flags: review?(bugmail.mozilla)
Assignee | ||
Updated•10 years ago
|
Attachment #8338237 -
Attachment is obsolete: true
Attachment #8338237 -
Flags: review?(bugmail.mozilla)
Comment 5•10 years ago
|
||
Should one of the attachments be obsolete here?
Assignee | ||
Updated•10 years ago
|
Attachment #712280 -
Attachment is obsolete: true
Comment 6•10 years ago
|
||
Comment on attachment 8340841 [details] [diff] [review] Separate animation out from layer code; Review of attachment 8340841 [details] [diff] [review]: ----------------------------------------------------------------- You need to remove DoFling from AsyncPanZoomController.h also. ::: gfx/layers/ipc/AsyncPanZoomController.cpp @@ +1311,5 @@ > + RequestContentRepaint(); > + } > + } else { > + // Bring the resolution back in sync with the zoom, in case we scaled down > + // the zoom while accelerating. Move this comment down a couple of lines, or just remove it entirely. It makes sense that we want to do a RequestContentRepaint after the animation is over. ::: gfx/layers/ipc/AsyncPanZoomController.h @@ +720,5 @@ > + > + virtual bool Sample(FrameMetrics& aFrameMetrics, > + const TimeDuration& aDelta) = 0; > + > + TimeDuration mRepaintTime; Rename this to mRepaintInterval, and change the constructor arg accordingly. Also add a comment on this class giving a quick summary of what it's for.
Attachment #8340841 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=fd0f419504bc
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/edc4afb4bc48 https://hg.mozilla.org/integration/mozilla-inbound/rev/a6008184956d
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/edc4afb4bc48 https://hg.mozilla.org/mozilla-central/rev/a6008184956d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•