Closed Bug 839913 Opened 10 years ago Closed 10 years ago

Fix HTMLAreaElement's stringifier


(Core :: DOM: Core & HTML, defect)

Not set



Tracking Status
firefox20 --- unaffected
firefox21 + fixed
firefox22 --- fixed


(Reporter: Ms2ger, Assigned: Ms2ger)



(Keywords: regression)


(2 files)

Looks like we lost support for HTMLAreaElement's stringifier; apparently we parse "stringifier attribute", but then ignore the "stringifier" part.
So there are three issues here:

1)  We need a test for this.
2)  We need to fix the bug.
3)  We need to make codegen throw on stringifier attributes, since it can't handle them....
Passing it to Andrea as this appears to be a regression from 839439 .Please feel free to reassign if needed.
Assignee: nobody → amarchesini
(In reply to Boris Zbarsky (:bz) from comment #1)
> 3)  We need to make codegen throw on stringifier attributes, since it can't
> handle them....

Or support stringifier attributes properly :)
Or that, but that's a good bit more work.  Patches accepted in the bug we have on that already.  ;)
Assignee: amarchesini → nobody
bz,Ms2ger : Can you please help with some context on user impact here ? Andrea has unassigned this bug and there is no one looking at it. If this has a potential user impact we should definitely have someone look at it else may be its not worth while tracking .
Attached patch Patch v1Splinter Review
I'll just do 1) and 2), then...
Assignee: nobody → Ms2ger
Attachment #718323 - Flags: review?(bzbarsky)
Try run for e5d3da4ab271 is complete.
Detailed breakdown of the results available here:
Results (out of 2 total builds):
    exception: 2
Builds (or logs if builds failed) available at:
The context is that this is a web-compat regression that's trivial to fix and hence I believe a must-fix.  I'm not sure why Andrea unassigned this.  :(
Comment on attachment 718323 [details] [diff] [review]
Patch v1

Attachment #718323 - Flags: review?(bzbarsky) → review+
Try run for 71522cdbbd5e is complete.
Detailed breakdown of the results available here:
Results (out of 27 total builds):
    success: 24
    warnings: 3
Builds (or logs if builds failed) available at:
Is this ready to land on m-c in preparation for uplift to Aurora?
Backed out for bustage.

/builds/slave/m-in-osx64-d-00000000000000000/build/obj-firefox/config/nsinstall -L /builds/slave/m-in-osx64-d-00000000000000000/build/obj-firefox/dom/interfaces/core -m 644 "_xpidlgen/nsIDocumentRegister.h" "../../../dist/include"
/builds/slave/m-in-osx64-d-00000000000000000/build/obj-firefox/config/nsinstall -L /builds/slave/m-in-osx64-d-00000000000000000/build/obj-firefox/dom/interfaces/events -m 644 "_xpidlgen/nsIDOMElementReplaceEvent.h" "../../../dist/include"
Traceback (most recent call last):
  File "/builds/slave/m-in-osx64-d-00000000000000000/build/config/", line 56, in <module>
  File "/builds/slave/m-in-osx64-d-00000000000000000/build/config/", line 48, in main
    execfile(script, frozenglobals)
  File "/builds/slave/m-in-osx64-d-00000000000000000/build/dom/bindings/", line 78, in <module>
  File "/builds/slave/m-in-osx64-d-00000000000000000/build/dom/bindings/", line 55, in main
    parser.parse(''.join(lines), fullPath)
  File "/builds/slave/m-in-osx64-d-00000000000000000/build/dom/bindings/parser/", line 4454, in parse
  File "/builds/slave/m-in-osx64-d-00000000000000000/build/other-licenses/ply/ply/", line 263, in parse
    return self.parseopt(input,lexer,debug,tracking,tokenfunc)
  File "/builds/slave/m-in-osx64-d-00000000000000000/build/other-licenses/ply/ply/", line 710, in parseopt
  File "/builds/slave/m-in-osx64-d-00000000000000000/build/dom/bindings/parser/", line 3353, in p_InterfaceMembers
  File "/builds/slave/m-in-osx64-d-00000000000000000/build/dom/bindings/parser/", line 2269, in addExtendedAttributes
  File "/builds/slave/m-in-osx64-d-00000000000000000/build/dom/bindings/parser/", line 2957, in handleExtendedAttribute
    [attr.location, self.location])
WebIDL.WebIDLError: error: Methods must not be flagged as [SetterThrows], HTMLAreaElement.webidl line 23:12
HTMLAreaElement.webidl line 27:2
make[6]: *** [ParserResults.pkl] Error 1
make[5]: *** [bindings_export] Error 2
make[4]: *** [export_tier_platform] Error 2
make[3]: *** [tier_platform] Error 2
make[2]: *** [default] Error 2
make[1]: *** [realbuild] Error 2
make: *** [build] Error 2
Yes, I was aware.
(In reply to :Ms2ger from comment #15)
> Yes, I was aware.

bz made me do it!!! :D
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Attached patch BackportSplinter Review
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 839439
User impact if declined: Possibility of sites breaking.
Testing completed (on m-c, etc.): On m-c, passes tests, including the included one.
Risk to taking this patch (and alternatives if risky): Low. The fix is simple and well-understood. Alternative is backing out bug 839439.
String or UUID changes made by this patch: None.
Attachment #721367 - Flags: approval-mozilla-aurora?
Comment on attachment 721367 [details] [diff] [review]

Approving the low risk fwd fix for uplift.
Attachment #721367 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: checkin-needed
Depends on: 851891
Keywords: regression
You need to log in before you can comment on or make changes to this bug.