Closed Bug 839950 Opened 8 years ago Closed 8 years ago

Cannot search by Change History on multi select fields.

Categories

(Bugzilla :: Query/Bug List, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.2

People

(Reporter: mtyson, Assigned: mtyson)

Details

Attachments

(1 file, 1 obsolete file)

In query.cgi, the Change History column sources its fields from the bugs table, which means it doesn't list any multi select fields as an option to search from.

Attached is a patch to allow searching by change history on multi select fields.
Attachment #712344 - Flags: review?
Comment on attachment 712344 [details] [diff] [review]
Patch to add change history multi select searching

This change is inconsistent with 1) the comment above this subroutine which specifies "fields from the bugs table", and 2) the code later in this subroutine which takes care of multi-select fields, see bug 400569. These comments must be fixed. It would be good to also fix the POD for this subroutine, while you are on it.

Also, did you make sure that the code in Search.pm works correctly with multi-select fields?
Attachment #712344 - Flags: review? → review-
I've updated the comments.

I've done testing on searching a multi select by change history and everything appears to be working as I would expect.
Attachment #712344 - Attachment is obsolete: true
Attachment #713226 - Flags: review?(LpSolit)
Comment on attachment 713226 [details] [diff] [review]
Patch to add change history multi select searching

>=== modified file 'Bugzilla/Bug.pm'

>+# Returns a list of currently active and editable bug fields,
>+# including with multi select fields.

s/with//


Thanks for the patch! r=LpSolit
Attachment #713226 - Flags: review?(LpSolit) → review+
I will apply the patch without POD, so that it applies cleanly to all branches.
Status: NEW → ASSIGNED
Flags: approval4.4+
Flags: approval4.2+
Flags: approval+
Target Milestone: --- → Bugzilla 4.2
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Bug.pm
Committed revision 8580.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/Bug.pm
Committed revision 8520.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified Bugzilla/Bug.pm
Committed revision 8188.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Added to relnotes for 4.4rc2 and 4.2.5.
You need to log in before you can comment on or make changes to this bug.