Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Cannot search by Change History on multi select fields.

RESOLVED FIXED in Bugzilla 4.2

Status

()

Bugzilla
Query/Bug List
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Matt Tyson, Assigned: Matt Tyson)

Tracking

Bugzilla 4.2
Bug Flags:
approval +
approval4.4 +
approval4.2 +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 712344 [details] [diff] [review]
Patch to add change history multi select searching

In query.cgi, the Change History column sources its fields from the bugs table, which means it doesn't list any multi select fields as an option to search from.

Attached is a patch to allow searching by change history on multi select fields.
Attachment #712344 - Flags: review?

Comment 1

5 years ago
Comment on attachment 712344 [details] [diff] [review]
Patch to add change history multi select searching

This change is inconsistent with 1) the comment above this subroutine which specifies "fields from the bugs table", and 2) the code later in this subroutine which takes care of multi-select fields, see bug 400569. These comments must be fixed. It would be good to also fix the POD for this subroutine, while you are on it.

Also, did you make sure that the code in Search.pm works correctly with multi-select fields?
Attachment #712344 - Flags: review? → review-
(Assignee)

Comment 2

5 years ago
Created attachment 713226 [details] [diff] [review]
Patch to add change history multi select searching

I've updated the comments.

I've done testing on searching a multi select by change history and everything appears to be working as I would expect.
Attachment #712344 - Attachment is obsolete: true
Attachment #713226 - Flags: review?(LpSolit)

Comment 3

5 years ago
Comment on attachment 713226 [details] [diff] [review]
Patch to add change history multi select searching

>=== modified file 'Bugzilla/Bug.pm'

>+# Returns a list of currently active and editable bug fields,
>+# including with multi select fields.

s/with//


Thanks for the patch! r=LpSolit
Attachment #713226 - Flags: review?(LpSolit) → review+

Comment 4

5 years ago
I will apply the patch without POD, so that it applies cleanly to all branches.
Status: NEW → ASSIGNED
Flags: approval4.4+
Flags: approval4.2+
Flags: approval+
Target Milestone: --- → Bugzilla 4.2

Comment 5

5 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Bug.pm
Committed revision 8580.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/Bug.pm
Committed revision 8520.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified Bugzilla/Bug.pm
Committed revision 8188.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 6

5 years ago
Added to relnotes for 4.4rc2 and 4.2.5.
You need to log in before you can comment on or make changes to this bug.