839956 - underlines in SVG text drawn with the wrong size

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cameron McCormack (:heycam)]

With svg.text.css-frames.enabled true, text decorations don't seem to be rendered with the correct thickness.  Try opening layout/reftests/svg/text/simple-underline.txt and pressing {Cmd,Ctrl}+Plus and notice that the underline stays at its original thickness.

Comment 2

[Robert Longson [:longsonr]]

See http://www.w3.org/Graphics/SVG/Test/20110816/harness/htmlObjectApproved/text-text-03-b.html too where the decoration is basically invisible when the SVG document is shown embedded in the html page but appears when you select view in tab.

Comment 3

[Cameron McCormack (:heycam)]

Also if you view http://www.w3.org/Graphics/SVG/Test/20110816/svg/text-text-03-b.svg the strike through decoration is not positioned correctly.

If I disable font size scaling by making UpdateFontSizeScaleFactor return early, then the decorations all look OK.

Comment 4

[Cameron McCormack (:heycam)]

Attachment: patch for size

The font size scale factor should not have taken the CSS:device pixel ratio into account.  This fixes the decoration thickness, but not the position of the strike through decoration, which I'll look into with a separate patch.

Comment 5

[Cameron McCormack (:heycam)]

Attachment: patch for size

Comment 6

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ff1755d6359

Comment 7

[Cameron McCormack (:heycam)]

Text decoration size/position is currently only correct when mFontSizeScaleFactor is 1.  The patch above just ensures that we get 1 for normal-ish font-sizes on text that hasn't been scaled.

Comment 8

[Cameron McCormack (:heycam)]

Attachment: patch for size and position when mFontSizeScaleFactor != 1

Here's the solution for that.  We weren't getting in to the nsLayoutUtils::GetInflationFor code that looks at the SVG text's font size scale factor.  So get it here, when we get the inflated metrics for text decorations.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0ff1755d6359

Comment 10

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ebbf1484ca37

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ebbf1484ca37