Closed
Bug 839962
Opened 11 years ago
Closed 11 years ago
Change some XPCOM refcount and thread NS_ASSERTIONS to fatal MOZ_ASSERTs
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
Attachments
(2 files)
|
26.15 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
|
27.61 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Lots of XPCOM code still uses NS_ASSERTION, which just logs a warning on assertion failure. These patches switch some NS_ASSERTIONs to MOZ_ASSERTs for some refcount and thread assertions that seem important enough for fatal assertions in debug builds. Here is a green try run (for debug builds with these MOZ_ASSERTS): https://tbpl.mozilla.org/?tree=Try&rev=04f411581d3b
Attachment #712352 -
Flags: review?(benjamin)
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #712355 -
Flags: review?(benjamin)
|
||
Updated•11 years ago
|
Attachment #712352 -
Flags: review?(benjamin) → review+
|
|
||
Updated•11 years ago
|
Attachment #712355 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b725f0b2e83 https://hg.mozilla.org/integration/mozilla-inbound/rev/46b409b1fa04
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1b725f0b2e83 https://hg.mozilla.org/mozilla-central/rev/46b409b1fa04
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•