Closed Bug 839962 Opened 9 years ago Closed 9 years ago

Change some XPCOM refcount and thread NS_ASSERTIONS to fatal MOZ_ASSERTs

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21
Tracking Status
firefox20 --- wontfix
firefox21 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

Details

Attachments

(2 files)

Lots of XPCOM code still uses NS_ASSERTION, which just logs a warning on assertion failure. These patches switch some NS_ASSERTIONs to MOZ_ASSERTs for some refcount and thread assertions that seem important enough for fatal assertions in debug builds.

Here is a green try run (for debug builds with these MOZ_ASSERTS):
https://tbpl.mozilla.org/?tree=Try&rev=04f411581d3b
Attachment #712352 - Flags: review?(benjamin)
Attachment #712355 - Flags: review?(benjamin)
Attachment #712352 - Flags: review?(benjamin) → review+
Attachment #712355 - Flags: review?(benjamin) → review+
You need to log in before you can comment on or make changes to this bug.