840014 - (tabs) it should be possible to open a private tab

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

tabs.open({private: true, url: ...}) should open a private tab.

See http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#351

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Hmm, on Fx I guess that default should be to open a tab in a non private window, and only open a tab in a private window if private is true, and ignore the private flag if there is an associated window (ie: require('windows').browserWindows.tabs.open()).

Make sense Irakli?

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #1)
> Hmm, on Fx I guess that default should be to open a tab in a non private
> window, and only open a tab in a private window if private is true, and
> ignore the private flag if there is an associated window (ie:
> require('windows').browserWindows.tabs.open()).
> 
> Make sense Irakli?

Makes sense, although I think we should always open tab in private window if `private: true` is set regardless weather it's called on specific window or not. Ignoring silently in later case can cause more harm IMO.

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/797

Pointer to Github pull-request

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 714980 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/797

Looking good, please address comments in pull before landing.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/dd39cbfbc23c04cca737fa5b0fdd0eaee61b6f49
Bug 840014: tabs.open() and windows.open() now take a isPrivate option

https://github.com/mozilla/addon-sdk/commit/8135fd0e32e52260ac46067bef8f4b2a8b45d683
bug 840014: checking isPrivateBrowsingSupported before opening a tab in private mode

https://github.com/mozilla/addon-sdk/commit/91d49303b4885c3f6489a840ceab69e2573d3ab2
bug 840014: windows.open with isPrivate: true dnw if private browsing permission is not allowed, and added a fix to tabs.open which would open a private tab in versions of Fennec that have no ptpb ui.

https://github.com/mozilla/addon-sdk/commit/645b982cf6f024862d5bc1277be3263a0834337d
bug 840014: fixing a window and tab test and adding tests of opening non private tabs when private browsing support is enabled

https://github.com/mozilla/addon-sdk/commit/97cc5d12dafe531a3d6aec30c09efeb05b3b4360
bug 840014: link to private-browsing docs from tab and windows docs

https://github.com/mozilla/addon-sdk/commit/ac63592a80d6d316b52b51941434e15feadb0699
Merge pull request #797 from erikvold/840014

Fix Bug 840014: tabs.open() and windows.open() now take a isPrivate option r=@Gozala