Remove ExpatDTD if obsolete

VERIFIED FIXED in mozilla0.9.3

Status

()

P2
minor
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: hjtoi-bugzilla, Assigned: hjtoi-bugzilla)

Tracking

({memory-footprint})

Trunk
mozilla0.9.3
memory-footprint
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Investigate if ExpatDTD is still used. If not, remove it from build and do cvs
remove. WellformedDTD is the one that seems to be in use right now.

Comment 1

18 years ago
Nobody uses it indeed. That will save a good chunk of code. Adding the footprint
keyword. 

Also, there are functions in nsExpatTokenizer that are only used by nsExpatDTD, 
and could be remove as well. For example, NS_New_Expat_Tokenizer isn't a good 
function to retain because it doesn't cache the filename needed for error 
reporting (c.f. "Additional Comments From rbs@maths.uq.edu.au 2001-06-02 02:28" 
on bug 82332).
Keywords: footprint
Priority: -- → P2
Whiteboard: [fixinhand]
Target Milestone: --- → mozilla0.9.3

Comment 3

18 years ago
What about also changing the semantics of the constructor in nsExpatTokenizer.h 
so that the URL is not set to null by default: this way, people won't be tempted 
to |new nsExpatTokenizer()|.
-          nsExpatTokenizer(nsString* aURL = nsnull);      
+          nsExpatTokenizer(nsString* aURL);      

The savings introduced by the changes look good to me. r=rbs.
Whiteboard: [fixinhand] → [fixinhand] r=rbs
nsXMLDocument.cpp includes nsExpatDTD.h, the include can be safely removed.
sr=jst
Fixed.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Whiteboard: [fixinhand] r=rbs

Comment 7

18 years ago
Marking verified per last comments.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.