840033 - [FACEBOOK][CONTACTS][es] When you link a contact to a facebook contact and there are no matching results, the message shown to indicate this overrides the list of all facebook contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Carlos Martínez Toral [:carlosmartinez]]

Attachment: Error message overriding first contact

Tested in unagi with Gecko-8ed37c2.Gaia-21cedfd.

STR:
1-Open contacts app
2-Create a contact with name aaaa
3-Go to settings
4-Enable facebook
5-Introduce valid credentials to login to your facebook account
6-Press select all and import the contacts
7-Open contact with name aaa
8-Press link button

Expected result --> A message indicating that there´s no matching contacts and then the list of all contacts should be shown

Actual result --> The message and the list of facebook contacts are shown but message is overriding first contact

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

This patch shows the message in a status banner based on UX's suggestions

Comment 2

[Jose Manuel Cantera]

Comment on attachment 712454 [details]
Patch v1

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Too long literals caused list overflow and a malfunctioning UI. See attachment
User impact if declined: High, bad perception of product quality. 
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): Low.

Comment 3

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/8f14f4b618f1baf0f637f68997bf1029b596bfcd

Comment 4

[Sergi]

I'm adding UX-P1 to the whiteboard because of the high impact it has from a UX perspective.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 712454 [details]
Patch v1

Approving low risk, status overlay horrible UI fix.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: Bugs still affected on b2g18 after 2/13 merge to v1.0.1 branch are affected on v1.0.1 branch.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 19e3d11268cb2ae0637183c75529682314b1f5c6
v1.0.1: 4595c60fed796dc83edd70ff57ff845cb329d37e

Comment 8

[rafael.marquez]

This is still happening on unagi

Comment 9

[rafael.marquez]

I am sorry, this comment is for other bug. Do not take this into account for this one. Thanks