840056 - [MMS][User Story] Audio playback from message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Peter Dolanjski [:pdol]]

UCID: Messages-055

User Story:
As a user, I want to be able to initiate the playback of audio directly from a message (sent or received).

Comment 1

[Casey Yee]

What is a common use case for sending audio using MMS?   Do you think that it's appropriate to use the standard music player layout for this or do you think we need to design new play controls to play-in-place within a message?

Flagging Peter for more info

Comment 2

[Kev Needham [:kev]]

I think it's appropriate to keep the experience consistent and implement the std music player, but it may be something we want to revisit later (or if it's a simpler implementation).

Comment 3

[Dietrich Ayala (:dietrich)]

Per partner and release-driver discussions, marking blocking- until all MMS functionality in bug 849867 is complete, allowing it all to be uplifted at once to avoid SMS bustage.

Comment 4

[Casey Yee]

After talking with Taipei, implementing using music player activity would also require the least effort.

We'll move forward with using this method.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

leo+ as this is a part of MMS and part of v1.1 to be included in leo+ queries. No_UPLIFT for now before the whole MMS is completed

Comment 6

[Maria Angeles Oteo (:oteo)]

Right now, Ayman is redefining the playback related functionality on MMS Wireframes based on the Browser Downloading ones done by Rob https://www.dropbox.com/s/aolxy3mzrdfvg17/browser-downloading.pdf 
Due to that, we believe they are a good starting point to start the implementation of those capabilities. 

A rough description of the expected behaviour:

When an MMS contains an audio file, a visual indication should be shown to indicate the availability of such a content. When the user taps on that visual indication, the proper "view activity" is invoked and the following is done by the "handler" activity: 

The audio file is opened by the media player, while the sound is played in the music player, the user has the option to "save" that content, if the user selects that option, a banner indicating the success/failure of the operation is shown when completed. If the user cancels the "play" operation, he is returned to the thread detail screen in SMS Application. All this code should be implemented by an activity (I suppose in the audio player). 

If the audio file has not been properly retrieved, this option will not be offered to end-users. If that is the case, the attachment will indicate there was an error. Clicking on that indication will ask the user for confirmation to try to download the file ("There was an error downloading attachment. Retry Download?").

Comment 7

[Borja Salguero [:borjasalguero]]

As agreed in Madrid assigned to Steve https://wiki.mozilla.org/Gaia/SMS by now.

Comment 8

[Corey Frang [:gnarf]]

It seems audio/amr is really common (bug 847006), no one can actually send me anything else it seems, so this is pretty much impossible to test on a device at the moment, but I will submit a patch.

We will need an image to represent an audio file in an mms, I currently have only a placeholder in place which I stole from our music app.

Comment 9

[Corey Frang [:gnarf]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/9494

Should get an image asset before we land this

Comment 10

[Victoria Gerchinhoren [:vicky]]

(In reply to Corey Frang [:gnarf] from comment #8)
> It seems audio/amr is really common (bug 847006), no one can actually send
> me anything else it seems, so this is pretty much impossible to test on a
> device at the moment, but I will submit a patch.
> 
> We will need an image to represent an audio file in an mms, I currently have
> only a placeholder in place which I stole from our music app.

Hi Corey, 
This is still work in progress but I am attaching the image, use it if you can easily update it later, if not, please wait to the definite one.

Thanks!

PS. assets live here: https://www.dropbox.com/sh/rdbkf2o2w2h1udu/TNnUzdT2Rq

Comment 11

[Victoria Gerchinhoren [:vicky]]

Attachment: WIP audio thumbnail for message

Comment 12

[Corey Frang [:gnarf]]

(In reply to Victoria Gerchinhoren from comment #10)
> 
> This is still work in progress but I am attaching the image, use it if you
> can easily update it later, if not, please wait to the definite one.
> 

It is easy to update later, just open a new bug about it!

Comment 13

[Victoria Gerchinhoren [:vicky]]

(In reply to Corey Frang [:gnarf] from comment #12)
> (In reply to Victoria Gerchinhoren from comment #10)
> > 
> > This is still work in progress but I am attaching the image, use it if you
> > can easily update it later, if not, please wait to the definite one.
> > 
> 
> It is easy to update later, just open a new bug about it!

Yes, treat this as final, we're going with it. 
Thanks!

Comment 14

[Julien Wajsberg [:julienw]]

Comment on attachment 743938 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/9494

r=me

thanks !

Comment 15

[Julien Wajsberg [:julienw]]

master: 50b73f78ed93496039039d9af64cdc6dba9803c2

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 50b73f78ed93496039039d9af64cdc6dba9803c2 to:
v1-train: 5f640a73f69e3b7e9f31662479e5d1825d5f274c