840057 - [MMS][User Story] Video playback from message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Peter Dolanjski [:pdol]]

UCID: Messages-056

User Story:
As a user, I want to be able to initiate the playback of video directly from a message (sent or received).

Comment 1

[Rick Waldron [:rwaldron]]

Just taking notes for myself.

...within some DOM handler...

new MozActivity({ 
  name: 'view',
  data: { 
    type: 'url', 
    url: video url 
  }
});

Comment 2

[Borja Salguero [:borjasalguero]]

+1 to Rick. We should use available activities on the device.

Comment 3

[Dietrich Ayala (:dietrich)]

Per partner and release-driver discussions, marking blocking- until all MMS functionality in bug 849867 is complete, allowing it all to be uplifted at once to avoid SMS bustage.

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

leo+ as this is a part of MMS and part of v1.1 to be included in leo+ queries. No_UPLIFT for now before the whole MMS is completed

Comment 5

[Maria Angeles Oteo (:oteo)]

Right now, Ayman is redefining the playback related functionality on MMS Wireframes based on the Browser Downloading ones done by Rob https://www.dropbox.com/s/aolxy3mzrdfvg17/browser-downloading.pdf 
Due to that, we believe they are a good starting point to start the implementation of those capabilities. 

A rough description of the expected behaviour:
When an MMS contains a video file, a visual indication should be shown to indicate the availability of such a content. When the user taps on that visual indication, the proper "view activity" is invoked and the following is done by the "handler" activity: 


The video file is opened by the video player, while the video is played in the video player, the user has the option to "save" that content, if the user selects that option, a banner indicating the success/failure of the operation is shown when completed. If the user cancels the "play" operation, he is returned to the thread detail screen in SMS Application. All this code should be implemented by an activity (I suppose in the video player). 


If the video file has not been properly retrieved, this option will not be offered to end-users. If that is the case, the attachment will indicate there was an error. Clicking on that indication will ask the user for confirmation to try to download the file ("There was an error downloading attachment. Retry Download?").

Comment 6

[Borja Salguero [:borjasalguero]]

As agreed in Madrid assigned to Steve https://wiki.mozilla.org/Gaia/SMS by now.

Comment 7

[Corey Frang [:gnarf]]

We will require an image to overlay on top of the video preview - Adding Victoria for this.

Comment 8

[Victoria Gerchinhoren [:vicky]]

(In reply to Corey Frang [:gnarf] from comment #7)
> We will require an image to overlay on top of the video preview - Adding
> Victoria for this.

Hi Corey,
Attaching the play icon in sprite, assets live here:
https://www.dropbox.com/sh/rdbkf2o2w2h1udu/TNnUzdT2Rq

Comment 9

[Victoria Gerchinhoren [:vicky]]

Attachment: PLay button in idle and press state (sprite)

Comment 10

[Corey Frang [:gnarf]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/9523

Comment 11

[David Flanagan [:djf]]

I notice that the test case only has a .ogv video in it. Does the MMS process involve transcoding so you know that you'll always be receiving this format? If not, I'd suggest you test with the .3gp videos that the user will be taking with the camera app...

And if you will be receiving .3gp videos there is all kinds of crazy you have to go through to get a preview image, including the deprecated-hwvideo permission and using shared/js/media/get_video_rotation.js to display the preview properly rotated. If you're just displaying a play button and a filename or something then you're okay, but if you need an actually poster image from the video, that's hard. I've done it for three different apps, so let me know if you need help with that.

And in particular, if the MMS app will have the deprecated-hwvideo permission then you have to take extra steps to play nice with Camera, Gallery and Video because of hardware contention issues.

Comment 12

[Rick Waldron [:rwaldron]]

r=me

Comment 13

[Corey Frang [:gnarf]]

(In reply to David Flanagan [:djf] from comment #11)
> And if you will be receiving .3gp videos there is all kinds of crazy you
> have to go through to get a preview image, including the deprecated-hwvideo
> permission and using shared/js/media/get_video_rotation.js to display the
> preview properly rotated. If you're just displaying a play button and a
> filename or something then you're okay, but if you need an actually poster
> image from the video, that's hard. I've done it for three different apps, so
> let me know if you need help with that.

I actually wouldn't mind your eyes & hands on the preview of videos.

I just made it a play button overlay on top of a video element, and was kinda upset that the video itself doesn't seem to show up in a `<video src=''>`... This just seemed like a failing of Gecko, not a place where I should have to write any code though.  IMO we shouldn't need any code gaia side to preview 3gp using a video tag, and if we do, that needs to be fixed in gecko.  Maybe I'm missing some obvious issue with that plan though...

Comment 14

[Julien Wajsberg [:julienw]]

Please file a bug in Gecko if you think there is something missing.

We might need to workaround this before it is fixed though.

Comment 15

[Julien Wajsberg [:julienw]]

reviewed on the PR

this is not bad, but we badly need UX input on this.

Comment 16

[Borja Salguero [:borjasalguero]]

We agree that we are going to move forward without the preview. This will be fixed here https://bugzilla.mozilla.org/show_bug.cgi?id=869244.

Comment 17

[Borja Salguero [:borjasalguero]]

Comment on attachment 744878 [details] [diff] [review]
https://github.com/mozilla-b2g/gaia/pull/9523

This code is ready! Thanks Corey for the patch.

Comment 18

[Borja Salguero [:borjasalguero]]

https://github.com/mozilla-b2g/gaia/commit/3dad6659d92eed2a6097deb2e7bf52015d037269

https://github.com/gnarf37/gaia/commit/055ae9f77c5ff83346ae5f3fc6d0a83c38cbdf70

Merged!

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 3dad6659d92eed2a6097deb2e7bf52015d037269 to:
v1-train: 5f63bf6808a17eb43c4fe7894171f35816e7ac9d