Closed
Bug 840140
Opened 11 years ago
Closed 11 years ago
BaselineCompiler: Limit number of actual arguments
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
We currently fail tests/js1_5/Array/regress-350256-02.js with a "too much recursion" error. This test tries to call a function with > 491,520 arguments (getMaxArgs() in the shell). v8 also throws an exception (after 125,000 arguments). Easiest fix seems to be to not enter the baseline JIT if the number of actual args is > 50,000 or something.
|
||
Comment 1•11 years ago
|
||
Makes sense.
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #712570 -
Flags: review?(kvijayan)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 712570 [details] [diff] [review] Patch Review of attachment 712570 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the late review. The bugmail for this somehow slipped through the cracks.
Attachment #712570 -
Flags: review?(kvijayan) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
No problem, would have pinged if it was urgent :) https://hg.mozilla.org/projects/ionmonkey/rev/87b081253d26
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•