Closed Bug 840179 Opened 7 years ago Closed 7 years ago

txExecutionState.cpp:211:77: warning: suggest parentheses around '&&' within '||' [-Wparentheses]

Categories

(Core :: XSLT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

GCC build warning:
{
content/xslt/src/xslt/txExecutionState.cpp:211:77: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
}

Code:
{
211     NS_ASSERTION(var->mExpr && !var->mFirstInstruction ||
212                  !var->mExpr && var->mFirstInstruction,
213                  "global variable should have either instruction or expression");
}

Trivial fix -- just need parens around each of the condition lines there.
CC'ing peterv in case he's up for stealing the review. :)
https://hg.mozilla.org/mozilla-central/rev/1bcc3c56b011
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.