840179 - txExecutionState.cpp:211:77: warning: suggest parentheses around '&&' within '||' [-Wparentheses]

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave 12/9 - 1/6)]

GCC build warning:
{
content/xslt/src/xslt/txExecutionState.cpp:211:77: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
}

Code:
{
211     NS_ASSERTION(var->mExpr && !var->mFirstInstruction ||
212                  !var->mExpr && var->mFirstInstruction,
213                  "global variable should have either instruction or expression");
}

Trivial fix -- just need parens around each of the condition lines there.

Comment 1

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave 12/9 - 1/6)]

Attachment: trivial fix: just add the parens

Comment 2

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave 12/9 - 1/6)]

CC'ing peterv in case he's up for stealing the review. :)

Comment 3

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave 12/9 - 1/6)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1bcc3c56b011

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1bcc3c56b011