840189 - Mark XSLT subdirs w/ .cpp files as FAIL_ON_WARNINGS

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Daniel Holbert [:dholbert]]

With bug 840179 fixed, these directories are all warning-free on my machine, w/ both clang & g++:
  content/xslt/src/base/
  content/xslt/src/xml/
  content/xslt/src/xpath/
  content/xslt/src/xslt/

Filing this bug on marking them as FAIL_ON_WARNINGS.

Comment 1

[Daniel Holbert [:dholbert]]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=cf72e92a4611

Comment 2

[Daniel Holbert [:dholbert]]

Try run w/ fix for bug 840209 (the windows red in comment 1's try push):
  https://tbpl.mozilla.org/?tree=Try&rev=2d216670257e

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 4

[Daniel Holbert [:dholbert]]

CC'ing peterv in case he's up for stealing the review. :)

Comment 5

[Daniel Holbert [:dholbert]]

sicking: friendly review-ping

(trivial patch, & it'd be nice to land this before new warnings end up being introduced in these directories...)

Comment 6

[Daniel Holbert [:dholbert]]

Thanks! Try push before landing, to be sure this still works:
 https://tbpl.mozilla.org/?tree=Try&rev=9aa4ed4a11a2

Comment 7

[Daniel Holbert [:dholbert]]

Try looks good. Inbound's closed now, so I'll land this soon, once it's open.

Comment 8

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/93062f5adc02

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/93062f5adc02