840302 - oncall screen stays visible even when RIL:CallError message is sent to the content process

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Anshul]

Steps to reproduce.

1. Insert a SIM card with FDN(PIN2) enabled
2. Make an outgoing call to a number not in the FDN list

Expected behavior:
See an error message on the UI, just like we see for https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/telephony_helper.js#91 cases.

Observed Behavior:
The oncall screen stays up with no dialing number or timer but with end call and accept call button visible.

Comment 1

[Dietrich Ayala (:dietrich)]

Vivien, can you cc the right people to look at this?

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Etienne is back from PTO! :)

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Kev - another one where it would be good to know if this is a blocker from our partners, this is not a blocker from our perspective and we're getting very cheap with the +s.

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

Triage: since FDN is not within scope for Shira, end users will not be able to get into such state directly on the phone (needs to have FDN enabled from a different phone). Leo? as FDN feature is deferred there

Comment 5

[Anshul]

Joe, there are two GCF test cases related to STK Call Control command that are blocker for Shira and cause this issue as well. GCF TC 27.22.6.1.4 and 27.22.6.3.4.

Comment 6

[Ken Chang[:kenkai]]

Anshul,
  In the table B.1 of Spec. 31.124, the GCF TC 27.22.6.3.4 only needs to be tested when FDN is supported. 
  The Fixed Dialling Number service isn't enabled in the test parameters or steps of GCF TC 27.22.6.1.4. Can you please double check it again?

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

The error message returned from RIL should be "FDNBlockedError".
As I check https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/telephony_helper.js#91 it seems Dialer doesn't handle this error.

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

this seems like a common failure for TEF as well. TEF?
Per comment 6, Anshul, can you confirm this is a cert blocker for tef/shira release? since this is not linked to your CS blocker bug.

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

crdlc or etienne for comment 7?

Comment 10

[Etienne Segonzac (:etienne)]

(In reply to Joe Cheng [:jcheng] from comment #9)
> crdlc or etienne for comment 7?

Yep, we need an l10n key for the message that needs to be displayed and then it should be a matter of adding the case for this error in the TelephonyHelper.

Comment 11

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys! I can only confirm that, as Yoshi says, the "FDNBlockedError" (http://dxr.mozilla.org/mozilla-central/dom/system/gonk/ril_consts.js#l2263) is not currently handled in telephony_helper.js. So we just need to add this control and to show the appropriate message to the user ;-)

Requesting info from Victoria regarding the message to show to the user. Currently these are some of the messages we are showing: https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/locales/shared.en-US.properties We could reuse "emergencyDialogBodyBadNumber" (kind of misleading the name of the entry) but just in case you want to show to the user a more specific message ;-) Thanks!

Comment 12

[Germán Toro del Valle (:gtorodelvalle)]

Ups, forgot to request info from Victoria ;-)

Comment 13

[Anshul]

Carol, could you answer Ken's question regarding TC TC 27.22.6.3.4?

Comment 14

[Anshul]

Ken, I tried to reproduce the issue again but seems like some Moz change has fixed the issue. I am closing this bug.