Closed Bug 840312 Opened 9 years ago Closed 9 years ago

Cache the result of Tab.metadata (follow-up Bug 833003)

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 21

People

(Reporter: tetsuharu, Assigned: tetsuharu)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Depends on: 833003
Attachment #712659 - Flags: review?(bugmail.mozilla)
Attached patch part1: Add follow-upcomment (obsolete) — Splinter Review
I'm sorry. I should have added the comment in the patch of bug 833003.
Attachment #712660 - Flags: review?(bugmail.mozilla)
Comment on attachment 712659 [details] [diff] [review]
part0: Cache the result of Tab.metadata

Review of attachment 712659 [details] [diff] [review]:
-----------------------------------------------------------------

Good refactor, thanks.
Attachment #712659 - Flags: review?(bugmail.mozilla) → review+
Comment on attachment 712660 [details] [diff] [review]
part1: Add follow-upcomment

Review of attachment 712660 [details] [diff] [review]:
-----------------------------------------------------------------

This comment doesn't add anything of value over what's already in the code. If anything you could add a comment stating which scenario this makes a difference in (i.e. pages have width=device-width and user-scalable=no) and point to bug 833003. But I don't think that's really necessary either, people can look at the code history to find the relevant bug.
Attachment #712660 - Flags: review?(bugmail.mozilla) → review-
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #4)
> Comment on attachment 712660 [details] [diff] [review]
> part1: Add follow-upcomment
> 
> Review of attachment 712660 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This comment doesn't add anything of value over what's already in the code.
> If anything you could add a comment stating which scenario this makes a
> difference in (i.e. pages have width=device-width and user-scalable=no) and
> point to bug 833003. But I don't think that's really necessary either,
> people can look at the code history to find the relevant bug.

OK. I retract this patch.
Attachment #712660 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/674b9ae1ccd3
Assignee: nobody → saneyuki.s.snyk
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.