84054 - Mac: Cannot open anymore an appledouble/applesingle attachment

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect, P1)

Description

[Jean-Francois Ducarroz]

When I double click on an appledouble attachment, this one is not correctly
saved on the disk and therefore the file is useless.

Also, when you open a applesingle attachment, this one is correctly saved to the
disk but the signature of the file is wrong, therefore you cannot use (open) it
either (especially if it's an application).

Comment 1

[Jean-Francois Ducarroz]

nominating nsbeta1. This append in both 0.9.1 or 0.9.2 build.

Comment 2

[scottputterman]

putting on 0.9.1 radar

Comment 3

[Jean-Francois Ducarroz]

Attachment: proposed fix, v1

Comment 4

[Jean-Francois Ducarroz]

Attachment: proposed fix, v2 (the first one was incomplete)

Comment 5

[Jean-Francois Ducarroz]

The first part of the fix is to test if the content-type is either
MULTIPART_APPLEDOUBLE (appledouble) or APPLICATION_APPLEFILE (applesingle).
Before we were testing only APPLICATION_APPLEFILE which is also the type of the
first part of an appledouble attachment.

The second part of the fix is to not considere a file as not good if it doesn't
have a data fork when we are processing an applesingle attachment. That was
preventing us from setting the finder info of the file.

Comment 6

[varada]

r=varada

Comment 7

[David :Bienvenu]

sr=bienvenu

Comment 8

[Jean-Francois Ducarroz]

Fixed and checked in (TRUNK and BRANCH)

Comment 9

[esther]

Using branch build 2001-06-06 and trunk build 2001-06-13 on mac, I sent myself a
quicktime file using 4.7 (appledouble) and an eudora pure voice attachment with
Applesingle selected for sending attachments.  When I opened my mail with builds
above and double-clicked on the attachment then selected save, the files saved
correctly.  Viewing the info for the appledouble file and original file they
were exactly the same.  Double-clicking on the saved applesingle attachment
brought up the pure voice player.   Note, doing a save as using context menu
didn't save either of these correctly.  I think there is a separate bug for
that.  This is verified.