840580 - BaselineCompiler: IC for ToBool Null|Undefined

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S [:evilpie]]

Attachment: v1

This should help some v8 benchmarks, in combination with a ToBool IC for object.

Comment 1

[Kannan Vijayan [:djvj]]

Comment on attachment 712962 [details] [diff] [review]
v1

Review of attachment 712962 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  I think down the line, we want to extend this so that baseline can distinguish between null and undefined showing up at a site (my intuition is that it in most cases, if either of them show up, it'll be one of them, not both).

But that bridge can be crossed once we start on work to do stub amalgamation, which would be useful in this case.

Comment 2

[Tom S [:evilpie]]

https://hg.mozilla.org/projects/ionmonkey/rev/e86b8db0fe34